Merge lp://staging/~azzar1/unity-api/add-visible-role into lp://staging/unity-api
Proposed by
Andrea Azzarone
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~azzar1/unity-api/add-visible-role |
| Merge into: | lp://staging/unity-api |
| Diff against target: |
80 lines (+14/-2) 5 files modified
debian/changelog (+6/-0) include/unity/shell/launcher/CMakeLists.txt (+1/-1) include/unity/shell/launcher/QuickListModelInterface.h (+4/-1) test/qmltest/mocks/plugins/Unity/Launcher/Mocks/MockQuickListModel.cpp (+2/-0) test/qmltest/unity/shell/launcher/tst_Launcher.qml (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~azzar1/unity-api/add-visible-role |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Unity8 CI Bot | continuous-integration | Needs Fixing | |
| Unity Team | Pending | ||
|
Review via email:
|
|||
Description of the change
* Are there any related MPs required for this MP to build/function as expected?
No.
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes.
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| Unity8 CI Bot (unity8-ci-bot) wrote | # |
review:
Needs Fixing
(continuous-integration)
Unmerged revisions
- 270. By Andrea Azzarone
-
Add visible role to quicklistModel.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:270
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https:/
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/