Merge lp://staging/~azzar1/software-properties/depends-on-keyring into lp://staging/software-properties
Proposed by
Andrea Azzarone
| Status: | Merged |
|---|---|
| Approved by: | Sebastien Bacher |
| Approved revision: | 1016 |
| Merged at revision: | 1014 |
| Proposed branch: | lp://staging/~azzar1/software-properties/depends-on-keyring |
| Merge into: | lp://staging/software-properties |
| Diff against target: |
58 lines (+18/-4) 3 files modified
debian/changelog (+9/-0) debian/control (+2/-1) softwareproperties/GoaAuth.py (+7/-3) |
| To merge this branch: | bzr merge lp://staging/~azzar1/software-properties/depends-on-keyring |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sebastien Bacher | Approve | ||
|
Review via email:
|
|||
Commit message
Depends on gnome-keyring, which provides org.freedesktop
To post a comment you must log in.
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Revision history for this message
| Andrea Azzarone (azzar1) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thank you for the change, gnome-keyring should be fine but I'm unsure all desktops use/want it. What happens if the depends is missing? Could we make it a Recommends instead and somewhat handle/warn the user if it's missing?