Nux

Merge lp://staging/~azzar1/nux/nux-layout-nvi into lp://staging/nux

  1. nux-layout-nvi
  2. Merge into trunk
Proposed by Andrea Azzarone
Status: Needs review
Proposed branch: lp://staging/~azzar1/nux/nux-layout-nvi
Merge into: lp://staging/nux
Diff against target: 653 lines (+171/-294)
7 files modified
Nux/LayeredLayout.cpp (+15/-13)
Nux/LayeredLayout.h (+14/-11)
Nux/Layout.cpp (+71/-57)
Nux/Layout.h (+70/-26)
Nux/LinearLayout.cpp (+0/-156)
Nux/LinearLayout.h (+0/-30)
configure.ac (+1/-1)
To merge this branch: bzr merge lp://staging/~azzar1/nux/nux-layout-nvi
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Francis Ginther Abstain
Unity Team Pending
Review via email: mp+117236@code.staging.launchpad.net

Commit message

Use NVI for AddLayout/AddView/AddSpace to avoid to redefine a function's inherited default parameter value.

Description of the change

== Problem ==
nux::LinearLayout and nux::LayeredLayout redefine nux::Layout functions with default parameters. This is not advisable because default values are statically bound.

== Fix ==
Use NVI (no virtual implementation).

== Test ==
Not applicable.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Review was claimed by accident, please ignore.

review: Abstain
Reply
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:640
http://jenkins.qa.ubuntu.com/job/nux-ci/14/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/nux-raring-amd64-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nux-raring-armhf-ci/14/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/nux-raring-i386-ci/14/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/nux-ci/14/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

640. By Andrea Azzarone

Minor changes.

639. By Andrea Azzarone

Use NVI for AddLayout/AddView/AddSpace to avoid to redefine a function's inherited default parameter value.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches