Nux

Merge lp://staging/~azzar1/nux/lp-1228093 into lp://staging/nux

lp-1228093
Merge into trunk

Proposed by Andrea Azzarone on 2013-09-20

Status:

Rejected

Rejected by:

Marco Trevisan (Treviño) on 2014-10-07

Proposed branch:

lp://staging/~azzar1/nux/lp-1228093

Merge into:

lp://staging/nux

Diff against target:

43 lines (+4/-4)

2 files modified

NuxGraphics/GraphicsDisplayX11.cpp (+2/-2)
tests/xtest-mouse-buttons.cpp (+2/-2)

To merge this branch:

bzr merge lp://staging/~azzar1/nux/lp-1228093

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2013-09-20
Unity Team		2013-09-20	Pending
Review via email: mp+186758@code.staging.launchpad.net

Commit message

Disable buttons6/7 (mouse scroll left/right) for Ubuntu S.

Description of the change

== Problem ==
Dash content flickers when the touchpad is used to scroll it.

== Fix ==
Using Ubuntu S horizontal scrolling is enabled by default (and can't be disabled from g-c-c). If you have two finger scrolling enabled it's easy to get this problem. So for the moment let's just disable button6/7 in nux. We don't really support it and we don't use it in unity. Fix it in a proper way requires an API break.

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2013-09-20:

Mh, instead of this I think it's better to workaround the issue in unity... By ignoring the horizontal scrolling there (otherwise this would break alt+tab horiz scrolling)...

We can instead define two more mouse states like NUX_EVENT_MOUSEWHEEL_HORIZONTAL and NUX_EVENT_MOUSEWHEEL_VERTICAL. This won't break the api and we can then verify the type of scroll event by just checking the event's mouse_state at unity level.