Merge lp://staging/~azzar1/gtk/fix-781931 into lp://staging/~ubuntu-desktop/gtk/ubuntugtk3

Proposed by Andrea Azzarone
Status: Needs review
Proposed branch: lp://staging/~azzar1/gtk/fix-781931
Merge into: lp://staging/~ubuntu-desktop/gtk/ubuntugtk3
Diff against target: 26 lines (+14/-0)
2 files modified
debian/patches/110_fix_stealing_focus.diff (+13/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp://staging/~azzar1/gtk/fix-781931
Reviewer Review Type Date Requested Status
Sebastien Bacher Needs Information
Review via email: mp+102036@code.staging.launchpad.net

Commit message

Description of the change

== Problem ==
New windows are moved to front but don't take focus.

== Fix ==
From http://standards.freedesktop.org/wm-spec/latest/ar01s05.html:
«Clients can obtain the timestamp that caused its first window to appear from the DESKTOP_STARTUP_ID environment variable, if the app was launched with startup notification. ***If the client does not know the timestamp of the user interaction that caused the first window to appear (e.g. because it was not launched with startup notification), then it should not set the property for that window***. The special value of zero on a newly mapped window can be used to request that the window not be initially focused when it is mapped.»

So GDK_X11_DISPLAY (x11_screen->display)->user_time is just incorrect.

To post a comment you must log in.
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks but could you upstream that patch and add the bugzilla url and some description to the patch informations?

review: Needs Information

Unmerged revisions

183. By Andrea Azzarone

Fix bug #781931.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches