Compiz

Merge lp://staging/~azzar1/compiz/fix-blank-window into lp://staging/compiz/0.9.12

  1. fix-blank-window
  2. Merge into 0.9.12
Proposed by Andrea Azzarone
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 3927
Merged at revision: 3930
Proposed branch: lp://staging/~azzar1/compiz/fix-blank-window
Merge into: lp://staging/compiz/0.9.12
Diff against target: 34 lines (+1/-6)
2 files modified
plugins/animation/include/animation/animeffect.h (+0/-2)
plugins/animation/src/animation.cpp (+1/-4)
To merge this branch: bzr merge lp://staging/~azzar1/compiz/fix-blank-window
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+251392@code.staging.launchpad.net

Commit message

Do not cache textures in animation.cpp.

Description of the change

Caching textures in animation.cpp causes blank-window issue on nvidia systems. For what I understand we don't need to do that anymore. Probably is a leftover of the c++ port. Everything work just fine here even without caching textures.

Thanks to Arthur Huillet for the help.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3927
http://jenkins.qa.ubuntu.com/job/compiz-ci/29/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-amd64-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-armhf-ci/19
    SUCCESS: http://jenkins.qa.ubuntu.com/job/compiz-vivid-i386-ci/19

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/compiz-ci/29/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Cool... Nice catch.

This was indeed an unneeded leftover.
Tested here (intel/radeon) works fine.

review: Approve
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

Nice work :D. Its curious that creating a copy of a TFP-d texture might cause corruption on the driver side. Perhaps this is something that should be reported to nvidia too?

Revision history for this message
Stephen M. Webb (bregma) wrote :

nVidia are definitely already aware of the problem.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches