Compiz Core

Merge lp://staging/~azzar1/compiz-core/scale-left-padding into lp://staging/compiz-core/0.9.5

scale-left-padding
Merge into 0.9.5

Proposed by Andrea Azzarone on 2012-01-15

Status:

Rejected

Rejected by:

Sam Spilsbury on 2012-01-19

Proposed branch:

lp://staging/~azzar1/compiz-core/scale-left-padding

Merge into:

lp://staging/compiz-core/0.9.5

Diff against target:

65 lines (+14/-3)

2 files modified

plugins/scale/scale.xml.in (+7/-0)
plugins/scale/src/scale.cpp (+7/-3)

To merge this branch:

bzr merge lp://staging/~azzar1/compiz-core/scale-left-padding

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Sam Spilsbury		2012-01-15	Needs Information on 2012-01-17
Review via email: mp+88622@code.staging.launchpad.net

Description of the change

Add a left padding option to the scale plugin. We really need it to fix the bug #893670.
Using the padding to create the dnd redirect window will fix also the bug #727904.

lp://staging/~azzar1/compiz-core/scale-left-padding updated on 2012-01-15

2912. By Andrea Azzarone on 2012-01-15: Ops

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-01-17:

The scale plugin needs tests, but thats outside the scope of this merge review

review: Approve

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-01-17:

OK, I did some thinking about this and this comes back to an idea I've had for a while but not yet had time to implement.

We need to have a concept of "overlay struts" in the EWMH or our own extension to it, eg _COMPIZ_NET_OVERLAY_STRUT. Such "struts" allow us to specify parts of the screen which are never available for output operations. That way the scale, expo and other plugins would be able to adjust all layouts to compensate for this lack of screen space on screen-level operations.

_COMPIZ_IS_NET_OVERLAY would be a property on any window which also sets _NET_WM_STRUT or _NET_WM_STRUT_PARTIAL which basically indicates that the area is reserved for both window and screen level operations. So the scale plugin would adjust its layout and dnd window accordingly

review: Needs Information

Revision history for this message

Sam Spilsbury (smspillaz) wrote on 2012-01-19:

Now that we are using overlay struts, this is redundant

Unmerged revisions

2912. By Andrea Azzarone on 2012-01-15: Ops
2911. By Andrea Azzarone on 2012-01-15: Add a left padding option to the scale plugin.
2910. By Daniel van Vugt on 2012-01-13: Fix 'make install' failing to install headers properly (LP: #915186)
2909. By Daniel van Vugt on 2012-01-12: Fix warnings due to signed/unsigned int comparison in CompTimer. (LP: #893998)
Merged: lp:~smspillaz/compiz-core/fix-timer-warnings-893998
without any of its prereqs.