BAMF

Merge lp://staging/~azzar1/bamf/bamf-sn into lp://staging/bamf

bamf-sn
Merge into trunk

Proposed by Andrea Azzarone on 2016-01-20

Status:

Merged

Approved by:

Marco Trevisan (Treviño) on 2016-03-21

Approved revision:

634

Merged at revision:

625

Proposed branch:

lp://staging/~azzar1/bamf/bamf-sn

Merge into:

lp://staging/bamf

Diff against target:

823 lines (+340/-18)

17 files modified

configure.ac (+6/-1)
debian/changelog (+6/-0)
debian/libbamf3-2.symbols (+1/-0)
lib/libbamf-private/org.ayatana.bamf.view.xml (+1/-0)
lib/libbamf/bamf-view.c (+51/-0)
lib/libbamf/bamf-view.h (+5/-2)
src/Makefile.am (+2/-0)
src/bamf-application.c (+19/-0)
src/bamf-control.c (+4/-2)
src/bamf-control.h (+2/-2)
src/bamf-legacy-screen.c (+98/-1)
src/bamf-legacy-screen.h (+14/-8)
src/bamf-matcher.c (+54/-2)
src/bamf-matcher.h (+4/-0)
src/bamf-view.c (+67/-0)
src/bamf-view.h (+4/-0)
tests/bamfdaemon/Makefile.am (+2/-0)

To merge this branch:

bzr merge lp://staging/~azzar1/bamf/bamf-sn

Low

Triaged

Link a bug report

Reviewer	Review Type	Date Requested	Status
Marco Trevisan (Treviño)		2016-01-20	Approve on 2016-03-21
PS Jenkins bot (community)	continuous-integration		Approve on 2016-02-29
Andrea Azzarone (community)			Needs Resubmitting on 2016-02-29
Review via email: mp+283314@code.staging.launchpad.net

Commit message

BamfView: add "starting" property which is true when an application has been launched

Description of the change

Add "starting" property to bamf views using startup notification. I suppose I also need to bump the API.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-20:

FAILED: Continuous integration, rev:628
http://jenkins.qa.ubuntu.com/job/bamf-ci/123/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-xenial-amd64-ci/4/console
FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-xenial-armhf-ci/4/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/bamf-ci/123/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2016-01-20:

FAILED: Continuous integration, rev:629
http://jenkins.qa.ubuntu.com/job/bamf-ci/124/
Executed test runs:
FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-xenial-amd64-ci/5/console
FAILURE: http://jenkins.qa.ubuntu.com/job/bamf-xenial-armhf-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/bamf-ci/124/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2016-02-02:

Wondering why we can't just use org.gtk.gio.DesktopAppInfo signal instead of SN?

This could have been implemented just for a BamfApplication, but that's fine for a view as well.

In case of SN_MONITOR_EVENT_CANCELED: We should set the starting to false.
Also we should define a maximum amount of time to wait after setting a viuw as starting.

Plus, bump version to 0.5.3, so that we can set set as build-dependency on unity side.

On debian side there's some work to do as well:
debian/control: add libstartup-notification0-dev as build-dependency
debian/changelog: bump version
debian/libbamf3-2.symbols: add new symbols (use 0replaceme for versioning, see previous examples)

review: Needs Fixing

lp://staging/~azzar1/bamf/bamf-sn updated on 2016-02-29

625. By Andrea Azzarone on 2016-02-25: Merge with trunk.
626. By Andrea Azzarone on 2016-02-25: Remove deprecated methods.
627. By Andrea Azzarone on 2016-02-25: Remove two paddings to avoid ABI break.
628. By Andrea Azzarone on 2016-02-25: Remove useless space.
629. By Andrea Azzarone on 2016-02-29: Add a timeout to avoid infinite starting animation in case of failing.
630. By Andrea Azzarone on 2016-02-29: Bump version and update symbols.