Elasticsearch Charm

Merge ~aym-frikha/charm-elasticsearch:bug-1748433 into ~elasticsearch-charmers/charm-elasticsearch:master

  1. Git
  2. lp:~aym-frikha/charm-elasticsearch
  3. bug-1748433
  4. Merge into master
Proposed by Aymen Frikha
Status: Merged
Approved by: Paul Collins
Approved revision: 7fb47b7f9116a690768cfa510f0186d23458430d
Merged at revision: 3b147f5fc1e28925882e60542761182072c04caa
Proposed branch: ~aym-frikha/charm-elasticsearch:bug-1748433
Merge into: ~elasticsearch-charmers/charm-elasticsearch:master
Diff against target: 47 lines (+4/-3)
3 files modified
hooks/charmhelpers/contrib/ansible/__init__.py (+1/-1)
metadata.yaml (+1/-0)
tasks/setup-ufw.yml (+2/-2)
Reviewer Review Type Date Requested Status
Paul Collins lgtm Approve
Tom Haddon Approve
Jacek Nykis (community) Needs Information
Review via email: mp+345476@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Jacek Nykis (jacekn) wrote :

Changes seem fine but can you confirm they are backwards compatible?

review: Needs Information
Revision history for this message
Tom Haddon (mthaddon) wrote :

I've confirmed this passes CI on bionic https://jenkins.canonical.com/is-mojo-ci/job/live-is-charm-test-elasticsearch-bionic/22/console (sorry, Canonical-only link). It also passes the upgrade and then redeploy test on trusty (https://jenkins.canonical.com/is-mojo-ci/job/live-is-charm-test-elasticsearch-trusty/59/console) and xenial (https://jenkins.canonical.com/is-mojo-ci/job/live-is-charm-test-elasticsearch-xenial/45/console)

review: Approve
Revision history for this message
Paul Collins (pjdc) :
review: Approve (lgtm)

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches