lp://staging/~axwalk/juju-core/null-provider-validate-initially-invalid

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp://staging/~go-bot/juju-core/trunk

Juju Engineering: Pending requested 2013-11-14

Diff: 79 lines (+24/-11)

2 files modified

provider/null/config_test.go (+11/-1)
provider/null/provider.go (+13/-10)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

2058. By Andrew Wilkins on 2013-11-14

provider/null: Validate must allow invalid old config

The EnvironmentSet is used to push secrets from the CLI
into state; before this, the config in state is invalid.

EnvironmentSet always calls the provider's Validate
method on the new and old config before setting the
config in state. Thus, the Validate method must cater
for the old config being invalid.

2057. By John A Meinel on 2013-11-13

[r=jameinel],[bug=1250149] typo: Fix a typo in a warning

We accidentally had "% should" rather than something like "%s should".
I went with "%q should" because that matched how we wrote the other
variable eariler in the message.

https://codereview.appspot.com/25900043/

2056. By John A Meinel on 2013-11-13

[r=jameinel],[bug=1250601] typo: fix typo in warning

bug #1250601

Just fix "upddated" to "updated"

https://codereview.appspot.com/25880043/

2055. By Tim Penhey on 2013-11-13

[r=thumper] instance container method tests

Be explicit in the container type equality.
Test the parsing of KVM.
Change the tests names to be consistent with the functions.

https://codereview.appspot.com/25460045/

2054. By Tim Penhey on 2013-11-13

[r=thumper] Initial kvm interfaces and mock implementation.

Lots of initial boilerplate.

https://codereview.appspot.com/25550043/

2053. By Ian Booth on 2013-11-13

[r=wallyworld],[bug=1249399] Change the default (deprecated) tools-url value from omit to "" to prevent errors in some situations.

2052. By Tim Penhey on 2013-11-12

[r=thumper] Factor out container directory functions.

Functions for dealing with the container definition
directories are moved to the container package.

https://codereview.appspot.com/24980043/

2051. By William Reade on 2013-11-12

[r=fwereade] cmd/juju: reinstate destroy-machine doc

https://codereview.appspot.com/25170043/

2050. By William Reade on 2013-11-12

[r=fwereade],[bug=1089291] fix lp:1089291

...which involved a lot more churn than I wanted, mainly because those
DestroyWhatevers methods really shouldn't ever have been on state in the
first place, and moving them turned out to be a ridiculous hassle.

Despite the mess, this branch really just involves:

1) moving multi-Destroy methods off state and onto the api
2) fixing/moving/renaming test things
3) hooking up a --force flag to destroy-machine
4) oh, and making the relevant api.Client methods a teeny tiny bit
   consistent.

https://codereview.appspot.com/24790044/

2049. By Tim Penhey on 2013-11-12

[r=thumper] Move the writing of the user-data to container.

Writing out the user-data is container agnostic.

https://codereview.appspot.com/24790043/