lp://staging/~axwalk/juju-core/lp1204388-log-warnings-stderr

Branch merges

Propose for merging

No branches dependent on this one.

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1204388: juju does not log warnings to console unless -v is set

High

Triaged

Link a bug report

Related blueprints

1529. By Andrew Wilkins on 2013-07-24

cmd: Enable logging to stderr by default

No change to levels: WARNING and up by default.

This change does lead to some redundant output,
particularly where errors occur. In those cases,
you'll typically see an ERROR log message and
finally some error message (often the same one).

1528. By Tim Penhey on 2013-07-24

[r=thumper] Trivial import testing prefix.

gc and jc prefix for imports.

https://codereview.appspot.com/11745043/

1527. By Tim Penhey on 2013-07-24

[r=thumper] Remove debugging code.

Slipped through the initial review.

https://codereview.appspot.com/11748043/

1526. By Tim Penhey on 2013-07-23

[r=thumper] Make agent/tools and remove state.Tools

This branch makes an agent/tools package that is all things tools.
The environs/tools package is merged in there. There is a test
to ensure that we don't bring in extra package dependencies to
tools, right now just "utils/set" and "version".

https://codereview.appspot.com/11561044/

1525. By Jeroen T. Vermeulen on 2013-07-23

[r=jtv] Unify state-file creation.

Each of the "physical" providers now has a bit of code in it to obtain the URL
of the state file. This is essentially generic between providers, so
repeating it is insane — doubly so because this way it's also too hard to
test.

And so in this branch I unify this in the file that's already responsible for
this kind of thing: environs/state.go. The repeated code actually occurs in
two forms: one creates an empty state file before getting its URL (Azure &
MAAS providers), the other just generates the URL based on the standard name
of the state file (EC2 & OpenStack providers). This is optimization based on
specific behaviours of different storage providers that is not expressed or
documented in the Storage interfaces: some will need a file to exist before it
can have a URL, others will deterministically generate a URL based on the
filename. Making use of that non-interface knowledge is probably not a good
thing. Right now we should optimize for clarity and maintainability. I refer
to Knuth's Law.

Oh yes, and now it's unit-tested. :)

1524. By Jeroen T. Vermeulen on 2013-07-23

[r=jtv] Drop unneeded internalStartInstance parameter.

In the past few days, one of the two code paths that called the openstack
provider's internalStance added the option (controlled by the config) to
assign a public IP to the instance. The other code path never did this.
It was awkward because it added a parameter to internalStartInstance which is
otherwise completely regular across the "physical" providers (EC2, OpenStack,
MAAS, Azure) and lends itself well to the factoring-out of common code.

Since then, however, the same parameter has also been added to the other code
path, so that it's completely regular between invocations. It means that
internalStartInstance doesn't need this as a parameter; it can figure out the
right choice for itself (and yay, in one place instead of identically in two).

And thus this branch brings the openstack provider back into the fold of
identically-structured interfaces among the Bootstrap / StartInstance /
internalStartInstance methods. This is crucial for the ongoing refactoring
process.

1523. By Dimiter Naydenov on 2013-07-23

[r=dimitern] state/api(server)/deployer: AssignedMachineTag

Last yet not implemented API call needed by the
deployer worker. Next in line is the actual
migration from state calls to API calls in the
deployer.

https://codereview.appspot.com/11713043/

R=themue

1522. By Raphaël Badin on 2013-07-23

[r=rvb] Azure provider: delete Virtual Network

This branch adds the deletion of the environment's Virtual Network and Affinity Group when the environment is destroyed. I could have divided the test TestDestroyDeletesVirtualNetworkAndAffinityGroup into two separate tests but since the initialization of the test is pretty long and, conceptually, the Virtual Network and the Affinity Group are linked together, I decided to go with one test.

1521. By Roger Peppe on 2013-07-23

[r=rogpeppe] utils: copy AttemptStrategy from goamz/aws.

The aws code, originally derived from the juju-core code,
allows for some neater ways of writing attempt-based code.
In particular it allows us to declare within the loop any variables retrieved
during the attempt.

 for attempt := attempts.Start(); attempt.Next(); {
  x, err := doSomething()
  if shouldRetry(err) && attempt.HasNext() {
   continue
  }
  if err != nil {
   return err
  }
  doSomethingWith(x)
 }

https://codereview.appspot.com/11680043/

1520. By Dave Cheney on 2013-07-23

[r=dave-cheney] scripts: more release tarball twiddling