Go Windows Azure Client Library

Merge lp://staging/~axwalk/gwacl/retry-rewind-request-body into lp://staging/gwacl

  1. retry-rewind-request-body
  2. Merge into trunk
Proposed by Andrew Wilkins
Status: Merged
Approved by: Andrew Wilkins
Approved revision: 233
Merged at revision: 232
Proposed branch: lp://staging/~axwalk/gwacl/retry-rewind-request-body
Merge into: lp://staging/gwacl
Diff against target: 80 lines (+39/-2)
2 files modified
x509dispatcher.go (+14/-2)
x509dispatcher_test.go (+25/-0)
To merge this branch: bzr merge lp://staging/~axwalk/gwacl/retry-rewind-request-body
Reviewer Review Type Date Requested Status
Ian Booth Approve
Review via email: mp+210118@code.staging.launchpad.net

Commit message

Rewind body when retrying POST/PUT/etc.

Azure may tell us to retry POST/PUT, which
may have a body. We must rewind the reader
if this happens.

Description of the change

Rewind body when retrying POST/PUT/etc.

Azure may tell us to retry POST/PUT, which
may have a body. We must rewind the reader
if this happens.

To post a comment you must log in.
Revision history for this message
Ian Booth (wallyworld) wrote :

Looks good.
Small typo:
+// to the beginning of the reader upong Close being called.

review: Approve
Revision history for this message
Go Bot (go-bot) wrote :

The attempt to merge lp:~axwalk/gwacl/retry-rewind-request-body into lp:gwacl failed. Below is the output from the failed tests.

./utilities/format -s
? launchpad.net/gwacl/example/management [no test files]
? launchpad.net/gwacl/example/storage [no test files]
? launchpad.net/gwacl/fork/http [no test files]
? launchpad.net/gwacl/fork/tls [no test files]

# launchpad.net/gwacl
deletedisk_test.go:8:5: cannot find package "launchpad.net/gocheck" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gocheck (from $GOROOT)
 /home/tarmac/gwacl-trees/src/launchpad.net/gocheck (from $GOPATH)
# launchpad.net/gwacl/dedent
deletedisk_test.go:8:5: cannot find package "launchpad.net/gocheck" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gocheck (from $GOROOT)
 /home/tarmac/gwacl-trees/src/launchpad.net/gocheck (from $GOPATH)
# launchpad.net/gwacl/logging
deletedisk_test.go:8:5: cannot find package "launchpad.net/gocheck" in any of:
 /usr/lib/go/src/pkg/launchpad.net/gocheck (from $GOROOT)
 /home/tarmac/gwacl-trees/src/launchpad.net/gocheck (from $GOPATH)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: