lp://staging/~axwalk/gwacl/management-api-307-redirects

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp://staging/gwacl at revision 231

Ian Booth: Approve on 2014-02-05

Diff: 185 lines (+104/-3)

3 files modified

x509dispatcher.go (+35/-1)
x509dispatcher_test.go (+56/-2)
x509session.go (+13/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1269835: azure provider handles 307 poorly	High	Fix Released
Bug #1276019: 307s are not followed other than for GET/HEAD, and headers are dropped from those	High	Fix Released

Link a bug report

Related blueprints

232. By Andrew Wilkins on 2014-02-05

Also check redirect status code for POST/DELETE, etc.

231. By Andrew Wilkins on 2014-02-04

Handle 307 redirects in the management API

The management API endpoints sometimes respond
with temporary redirects, which we most ignore,
except for when we don't and follow without
sending the requisite headers.

Instead of relying on net/http to handle redirects
we handle them inside gwacl. This allows us to
handle redirects on non-GET/HEAD requests, and
also to send all headers again.

Fixes lp:1276019

230. By Jeroen T. Vermeulen on 2014-01-31

[r=rvb][author=jtv] Document the newly announced A8 and A9 machine sizes, update pricing, and correct some disk sizes that should have been 605 GB but were accidentally written as 65 GB.

229. By Ian Booth on 2013-10-31

[r=][bug=1246320][author=wallyworld] This branch tweaks an earlier fix for the Azure API change. It reverts part of that fix and puts a base64 encode operation in the correct place.

228. By Ian Booth on 2013-10-31

[r=wallyworld] [r=][bug=][author=wallyworld] The first fix for the request eof issue worked by setting
Close=true on the http request. This seemed to be not always
work so a different approach is used (same as for goose).
Set DisableKeepAlives=true on the http transport.

227. By Ian Booth on 2013-10-31

[r=wallyworld],[bug=1246320] [r=][bug=1246320][author=wallyworld] Azure now requires certain requests to the management api to have an updated version number in the header. Such changes are supposed to be backwards compatible but msft failed not to break existing applications. This branch includes the new api version. It also base64 encodes customdata sent with the request, as this also appears to have changed from underneath us.

With these changes, juju bootstrap now completes and the bootstrap instance spins up. Previously it would have errored part way through bootstrap. There still may be an issue with cloud-init completing properly but if this is the case, it appears to be a separate issue and I'd like to land this branch to allow others with Azure credentials to help debug.

226. By Ian Booth on 2013-10-17

[r=wallyworld] [r=][bug=][author=wallyworld] Ensure Close = true when sending http requests.

This is needed to avoid this bug in Go's http lib:
https://code.google.com/p/go/issues/detail?id=4677

225. By Jeroen T. Vermeulen on 2013-09-24

[r=][bug=][author=jtv] Update role sizes: new A5 machine type, and new prices.

224. By Ian Booth on 2013-09-12

[r=][bug=][author=wallyworld] GetAnonymousFileURL() was panicing if there was an issue. I changed it to return an error. This is because juju sometimes needs to try and find a URL of a file but it doesn't know if it exists or not. So by using error and not panic, juju can handle the situation accordingly.

223. By Gavin Panella on 2013-08-29

[r=jameinel][bug=][author=allenap] Make tests verbose again.