Merge ~axino/mojo/+git/subordinates:axino into ~mojo-maintainers/mojo/+git/subordinates:master

Proposed by Junien Fridrick
Status: Merged
Approved by: Tom Haddon
Approved revision: f2c5f18b68e63e98696d91c4673c48fd6c257634
Merged at revision: 0b4a4cdaf7ae389c62f6b4352fe4d1afbb06c611
Proposed branch: ~axino/mojo/+git/subordinates:axino
Merge into: ~mojo-maintainers/mojo/+git/subordinates:master
Diff against target: 87 lines (+30/-5)
4 files modified
add-relations (+0/-2)
tests/test_juju.py (+23/-2)
tests/testdata/juju2.2.3-no-landscape-livepatch.json (+1/-1)
utils/juju.py (+6/-0)
Reviewer Review Type Date Requested Status
Tom Haddon Approve
Canonical IS Reviewers Pending
Review via email: mp+401974@code.staging.launchpad.net

Commit message

utils/juju.py : make already_related() properly detect a relation if the subordinate application name is different than the charm name

For example if telegraf is deployed as lp-telegraf and related

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tom Haddon (mthaddon) wrote :

One minor comment inline

Revision history for this message
Tom Haddon (mthaddon) wrote :

LGTM, thx.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches