Merge lp://staging/~awe/ubuntu/saucy/ofono/rilmodem-patch-cleanup into lp://staging/ubuntu/saucy/ofono

Proposed by Tony Espy
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 41
Merged at revision: 40
Proposed branch: lp://staging/~awe/ubuntu/saucy/ofono/rilmodem-patch-cleanup
Merge into: lp://staging/ubuntu/saucy/ofono
Prerequisite: lp://staging/~awe/ubuntu/saucy/ofono/fix-dbg-pkg
Diff against target: 1192 lines (+118/-363)
15 files modified
debian/changelog (+1/-0)
debian/patches/rilmodem-support.patch (+82/-205)
drivers/rilmodem/devinfo.c (+1/-1)
drivers/rilmodem/gprs-context.c (+1/-1)
drivers/rilmodem/gprs.c (+1/-40)
drivers/rilmodem/network-registration.c (+1/-1)
drivers/rilmodem/rilutil.c (+6/-4)
drivers/rilmodem/sim.c (+1/-3)
drivers/rilmodem/sms.c (+10/-91)
drivers/rilmodem/voicecall.c (+1/-1)
gril/grilio.c (+2/-2)
gril/parcel.c (+3/-3)
plugins/provision.c (+2/-2)
plugins/ril.c (+0/-3)
unit/test-grilunsol.c (+6/-6)
To merge this branch: bzr merge lp://staging/~awe/ubuntu/saucy/ofono/rilmodem-patch-cleanup
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Review via email: mp+180239@code.staging.launchpad.net

Description of the change

Cleaned up build-time rilmodem related warnings.

One functional change was to ril_parse_sms_response() which had was blatantly incorrect, although the bug didn't really effect normal operation.

I also changed all the driver structs in /driver/rilmodem to use the string constant RILMODEM.

Tested incoming and outgoing calls, text messages, and verified that mobile data works on maguro, running today's touch image.

To post a comment you must log in.
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: