Merge ~awe/network-manager/+git/ubuntu:add-configure-hook into network-manager:snap-1.10
Proposed by
Tony Espy
| Status: | Merged |
|---|---|
| Approved by: | Tony Espy |
| Approved revision: | 4e3e7e47096fa8c77590525c01e174e674730c8c |
| Merged at revision: | 6c2245c55f4227535db638afbc61559203b9f9b9 |
| Proposed branch: | ~awe/network-manager/+git/ubuntu:add-configure-hook |
| Merge into: | network-manager:snap-1.10 |
| Diff against target: |
157 lines (+73/-11) 3 files modified
snap-common/bin/snap-config.sh (+6/-6) snap-common/bin/snap-prop.sh (+5/-5) snap/hooks/configure (+62/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alfonso Sanchez-Beato (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This change adds the configure hook from the nm 1.2 snap. It also includes two minor robustness fixes related to the configure hook from the 1.2 snap.
Tested on a beta UC18 image, and verified that I can enable debug logging via the configure hook.
To post a comment you must log in.
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | # |
review:
Approve
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
LGTM