Merge ~awe/network-manager/+git/ubuntu:install-refresh-checks into network-manager:snap-1.10
Proposed by
Tony Espy
| Status: | Merged |
|---|---|
| Approved by: | Tony Espy |
| Approved revision: | ff5a236d3ac2153e986188cbd456783e93d71df4 |
| Merged at revision: | 41e316856be98c36c3bb8528b524619bdab5ebcf |
| Proposed branch: | ~awe/network-manager/+git/ubuntu:install-refresh-checks |
| Merge into: | network-manager:snap-1.10 |
| Diff against target: |
57 lines (+39/-0) 3 files modified
snap/hooks/install (+11/-0) snap/hooks/post-refresh (+11/-0) snap/hooks/utils.sh (+17/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alfonso Sanchez-Beato (community) | Approve | ||
| Ian Johnson (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
This commit adds install and post-refresh hooks to ensure that this snap isn't installed on desktop or Ubuntu Core 16. Both tested & verified, and also tested that an install on UC18 works as expected.
To post a comment you must log in.
Revision history for this message
| Tony Espy (awe) | # |
Revision history for this message
| Ian Johnson (anonymouse67) | # |
Revision history for this message
| Tony Espy (awe) | # |
Revision history for this message
| Ian Johnson (anonymouse67) | # |
review:
Approve
Revision history for this message
| Ian Johnson (anonymouse67) | # |
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | # |
Revision history for this message
| Alfonso Sanchez-Beato (alfonsosanchezbeato) wrote | # |
review:
Approve
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Just one clarification re: UC18 vs UC16 and core18 base snap.