cloud-init

Merge lp://staging/~avishai-ish-shalom/cloud-init/chef-refactor into lp://staging/~cloud-init-dev/cloud-init/trunk

chef-refactor
Merge into trunk

Proposed by Avishai Ish-Shalom on 2013-05-15

Status:

Rejected

Rejected by:

Scott Moser on 2017-06-06

Proposed branch:

lp://staging/~avishai-ish-shalom/cloud-init/chef-refactor

Merge into:

lp://staging/~cloud-init-dev/cloud-init/trunk

Diff against target:

359 lines (+212/-45)

3 files modified

cloudinit/config/cc_chef.py (+189/-42)
doc/examples/cloud-config-chef.txt (+17/-2)
templates/chef_client.rb.tmpl (+6/-1)

To merge this branch:

bzr merge lp://staging/~avishai-ish-shalom/cloud-init/chef-refactor

Related bugs:

Bug #847358: chef integration should support chef-solo	Low	Won't Fix
Bug #1027188: Cloud-init chef plugin should support more distros and installation methods	Low	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Scott Moser		2013-05-15	Needs Fixing on 2013-07-17
Review via email: mp+164009@code.staging.launchpad.net

Description of the change

Refactored cc_chef, added omnibus and chef-solo support

Revision history for this message

Scott Moser (smoser) wrote on 2013-07-17:

Avishai,
  Some comments. Sorry for taking so long to see this.
  * BIN_PATHS: I would really prefer that we just use PATH to look for executables. If the system is not set up to have PATH set correctly, the user should just use a full path. ie, the right way to get your executable found is to put it in PATH.
  * repo_path': '/var/lib/cloud/chef_repo'
    doesn't this fit better somewhere else ? I"m not entirely opposed to it, but it just seems like there is likely somewhere else to look. Also, if you're using /var/lib/cloud, please get it through 'cloud_dir' in the Paths object (cloud.paths).
  * some tests would be nice.

Thanks for the submission, sorry its taken so long to get around to it.

review: Needs Fixing

Revision history for this message

Avishai Ish-Shalom (avishai-ish-shalom) wrote on 2013-07-18:

i'll review my patch and get back to you.

On Wed, Jul 17, 2013 at 11:09 PM, Scott Moser <email address hidden> wrote:

> Review: Needs Fixing
>
> Avishai,
> Some comments. Sorry for taking so long to see this.
> * BIN_PATHS: I would really prefer that we just use PATH to look for
> executables. If the system is not set up to have PATH set correctly, the
> user should just use a full path. ie, the right way to get your executable
> found is to put it in PATH.
> * repo_path': '/var/lib/cloud/chef_repo'
> doesn't this fit better somewhere else ? I"m not entirely opposed to
> it, but it just seems like there is likely somewhere else to look. Also,
> if you're using /var/lib/cloud, please get it through 'cloud_dir' in the
> Paths object (cloud.paths).
> * some tests would be nice.
>
> Thanks for the submission, sorry its taken so long to get around to it.
>
> --
>
> https://code.launchpad.net/~avishai-ish-shalom/cloud-init/chef-refactor/+merge/164009
> You are the owner of lp:~avishai-ish-shalom/cloud-init/chef-refactor.
>

Revision history for this message

Scott Moser (smoser) wrote on 2017-06-06:

Hello,
Thank you for taking the time to contribute to cloud-init. Cloud-init has moved its revision control system to git. As a result, we are marking all bzr merge proposals as 'rejected'. If you would like to re-submit this proposal for review, please do so by following the current HACKING documentation at http://cloudinit.readthedocs.io/en/latest/topics/hacking.html .