Merge lp://staging/~autopilot/xpathselect/experimental into lp://staging/xpathselect

Proposed by Thomi Richards
Status: Merged
Approved by: Martin Pitt
Approved revision: 51
Merged at revision: 38
Proposed branch: lp://staging/~autopilot/xpathselect/experimental
Merge into: lp://staging/xpathselect
Diff against target: 1575 lines (+812/-188)
12 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+7/-0)
debian/control (+2/-2)
lib/node.h (+14/-6)
lib/parser.h (+91/-11)
lib/xpathquerypart.h (+34/-5)
lib/xpathselect.cpp (+31/-6)
lib/xpathselect.h (+1/-1)
test/dummynode.h (+62/-16)
test/test_parser.cpp (+503/-114)
test/test_xpath_simple.cpp (+5/-5)
test/test_xpath_tree.cpp (+61/-21)
To merge this branch: bzr merge lp://staging/~autopilot/xpathselect/experimental
Reviewer Review Type Date Requested Status
Martin Pitt (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+185846@code.staging.launchpad.net

Commit message

XPathSelect type changes and API/ABI bump.

Description of the change

Change for 1.4.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Martin Pitt (pitti) wrote :

I didn't re-review every single line of course, but structurally this seems okay. It properly bumps the SONAME and all that, and test coverage is fine.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: