Merge lp://staging/~autopilot/autopilot-qt/update-for-1.3 into lp://staging/autopilot-qt

FAILED: Continuous integration, rev:56
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/48/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/17/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/48/rebuild

Given that this is a Qt project I think we should try to adapt Qt quidelines.

Please use QString instead of std::string and one of Qt's shared pointer mechanisms. In fact, I'm not a big fan of shared pointers at all as in most cases they lead to bad design choices. So if not really necessary, try avoiding those.

I'd like to get the tests from the other MP merged before this for 2 reasons:
- knowing what this breaks before merging it
- the tests should still be released to raring while this will not.

> Given that this is a Qt project I think we should try to adapt Qt quidelines.
>
> Please use QString instead of std::string and one of Qt's shared pointer
> mechanisms.

Michael,

The GetName and GetPath methods are defined in xpathselect. We cannot use QStrings here since xpathselect does not (and should not) rely on Qt. Similarly, we use std::shared_ptr because that's what the interface defines.

> In fact, I'm not a big fan of shared pointers at all as in most
> cases they lead to bad design choices. So if not really necessary, try
> avoiding those.

I'm not sure what you mean - this is a classic case where shared_ptrs are necessary. Qt has it's fancy copy-on-write semantics which make passing objects around by value very cheap, but other toolkits don't have that. Since we're dealing with an interface that has to be toolkit-agnostic, we can't start using Qt's magic.

> I'd like to get the tests from the other MP merged before this for 2 reasons:
> - knowing what this breaks before merging it
> - the tests should still be released to raring while this will not.

I'm happy if you want to merge the tests with trunk, but please remember that trunk will never get released into raring. If you want your tests to go into raring you need to merge them in the stable branch.

FAILED: Continuous integration, rev:57
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/49/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/18/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/49/rebuild

7 + * Bump version number

Doesn't seem to describe what this changeset actually does

FAILED: Continuous integration, rev:57
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/50/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/19/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/19/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/50/rebuild

hmm.. doesn't build in jenkins because libpathselect >= 1.3 cannot be found. Is that already in some PPA I could add to the job?

> The GetName and GetPath methods are defined in xpathselect. We cannot use
> QStrings here since xpathselect does not (and should not) rely on Qt.
> Similarly, we use std::shared_ptr because that's what the interface defines.

Right... missed that.

Tests are merged to trunk and they fail because of the GatPath changes.

This would need to be merged with them and updated to pass CI (once Jenkins can find libxpathselect >= 1.3.)

> Doesn't seem to describe what this changeset actually does

The other change will be added to the changelog by jenkins due to the linked bug.

FAILED: Continuous integration, rev:57
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/51/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/20/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/20/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/51/rebuild

FAILED: Continuous integration, rev:58
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/52/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/21/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/21/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/52/rebuild

FAILED: Continuous integration, rev:59
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/53/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/22/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/22/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/53/rebuild

FAILED: Continuous integration, rev:60
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/54/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/24
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/23/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/54/rebuild

FAILED: Autolanding.
More details in the following jenkins job:
http://jenkins.qa.ubuntu.com/job/autopilot-qt-autolanding/26/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-autolanding/10
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-autolanding/10/console

PASSED: Continuous integration, rev:60
http://jenkins.qa.ubuntu.com/job/autopilot-qt-ci/55/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-amd64-ci/25
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-qt-raring-armhf-ci/24

Click here to trigger a rebuild:
http://s-jenkins:8080/job/autopilot-qt-ci/55/rebuild

CI job passes, tests pass. Approving now.