Merge lp://staging/~attente/indicator-keyboard/fix-flaky-test into lp://staging/indicator-keyboard
Proposed by
William Hua
| Status: | Merged |
|---|---|
| Approved by: | William Hua |
| Approved revision: | 102 |
| Merged at revision: | 99 |
| Proposed branch: | lp://staging/~attente/indicator-keyboard/fix-flaky-test |
| Merge into: | lp://staging/indicator-keyboard |
| Diff against target: |
110 lines (+22/-14) 4 files modified
configure.ac (+1/-1) lib/main.vala (+7/-1) po/indicator-keyboard.pot (+4/-4) tests/main.vala (+10/-8) |
| To merge this branch: | bzr merge lp://staging/~attente/indicator-keyboard/fix-flaky-test |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| PS Jenkins bot (community) | continuous-integration | Approve | |
| Mathieu Trudel-Lapierre | Approve | ||
|
Review via email:
|
|||
Commit message
Resolve flaky test by always forcing the delay.
The test used to kill a delay as soon as a change was observed on the action group which was activated. On slower systems, this caused an assertion failure because updating the dconf setting took much longer than getting the change notification.
Description of the change
The test used to kill a delay as soon as a change was observed on the action group which was activated. On slower systems, this caused an assertion failure because updating the dconf setting took much longer than getting the change notification.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Approve.