Merge lp://staging/~attente/gnome-settings-daemon/gnome-key-grabber into lp://staging/~ubuntu-desktop/gnome-settings-daemon/ubuntu

Proposed by William Hua
Status: Rejected
Rejected by: Sebastien Bacher
Proposed branch: lp://staging/~attente/gnome-settings-daemon/gnome-key-grabber
Merge into: lp://staging/~ubuntu-desktop/gnome-settings-daemon/ubuntu
Diff against target: 256 lines (+58/-29)
3 files modified
debian/changelog (+9/-0)
debian/patches/fix_input_switching_on_unity.patch (+13/-12)
debian/patches/fix_media_keys_on_unity.patch (+36/-17)
To merge this branch: bzr merge lp://staging/~attente/gnome-settings-daemon/gnome-key-grabber
Reviewer Review Type Date Requested Status
Sebastien Bacher Disapprove
Review via email: mp+202758@code.staging.launchpad.net

Commit message

Use the GNOME key grabber interface under Unity.

Description of the change

(This branch depends on https://code.launchpad.net/~attente/unity/gnome-key-grabber/+merge/202755)

Use the GNOME key grabber interface under Unity.

To post a comment you must log in.
453. By William Hua

Merge trunk.

454. By William Hua

Merge trunk.

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks William, I guess we need the new compiz to land before merging that one. Could you also/instead target lp:unity-settings-daemon (it's our "fork" of g-s-d for Unity)? (I wonder if we can just drop the key grabber there, following upstream move, since u-s-d is specific to Unity and compiz is the only option there)

455. By William Hua

Merge trunk.

Revision history for this message
Sebastien Bacher (seb128) wrote :

setting as rejected, that landing in u-s-d, g-s-d is not used under Unity anymore and that code is going to be cleaned out

review: Disapprove

Unmerged revisions

455. By William Hua

Merge trunk.

454. By William Hua

Merge trunk.

453. By William Hua

Merge trunk.

452. By William Hua

* debian/patches/fix_input_switching_on_unity.patch:
  - Update the current input source under Unity.
* debian/patches/fix_media_keys_on_unity.patch:
  - Stop using the legacy key grabber under Unity.

451. By William Hua

Handle input switching if under Unity.

450. By William Hua

Use shell key grabber under Unity.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: