Merge lp://staging/~attente/content-hub/content-hub-glib into lp://staging/content-hub

Proposed by William Hua
Status: Needs review
Proposed branch: lp://staging/~attente/content-hub/content-hub-glib
Merge into: lp://staging/content-hub
Prerequisite: lp://staging/~ken-vandine/content-hub/dbus_test_runner
Diff against target: 570 lines (+436/-6)
11 files modified
CMakeLists.txt (+7/-1)
debian/control (+23/-0)
debian/libcontent-hub-dev.install (+2/-2)
debian/libcontent-hub-glib-dev.install (+3/-0)
debian/libcontent-hub-glib0.install (+1/-0)
debian/libcontent-hub0.install (+1/-1)
libcontent-hub-glib.pc.in (+11/-0)
src/com/ubuntu/content/CMakeLists.txt (+62/-2)
tests/CMakeLists.txt (+1/-0)
tests/acceptance-tests/CMakeLists.txt (+11/-0)
tests/acceptance-tests/glib_test.cpp (+314/-0)
To merge this branch: bzr merge lp://staging/~attente/content-hub/content-hub-glib
Reviewer Review Type Date Requested Status
Ken VanDine Approve
Review via email: mp+311437@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-11-21.

Commit message

Add GLib bindings (LP: #1624437)

Description of the change

Add GLib bindings (LP: #1624437)

There's a GTK branch (wip/attente/mir-content-hub) that needs this for copy-paste support.

To post a comment you must log in.
Revision history for this message
Ken VanDine (ken-vandine) wrote : Posted in a previous version of this proposal

This fails to build on xenial with the following error:

gdbus-codegen: error: no such option: --c-generate-autocleanup

I'm guessing this is an option that was added since xenial

review: Needs Fixing
Revision history for this message
William Hua (attente) wrote : Posted in a previous version of this proposal

Thanks for catching that Ken, removed it since it's optional.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Thanks, this looks good now.

review: Approve
312. By William Hua

Skip the UAL lookup when run under autopkgtests to prevent an abort
from UAL

Unmerged revisions

312. By William Hua

Skip the UAL lookup when run under autopkgtests to prevent an abort
from UAL

311. By William Hua

Merge lp:~ken-vandine/content-hub/content-hub-glib-dbus_test_runner

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches