Code review comment for ~athos-ribeiro/ubuntu/+source/squid:merge-lp2018110-mantic

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Athos.

Package builds fine. dep8 passes. Dropped delta is OK. It's a pity that we have to use -Wno-error=maybe-uninitialized on ppc64el due to LTO; I wonder if it makes sense to submit a bug upstream and/or try to fix the issues (although I understand that upstream is very picky when reviewing changes and these fixes usually end up being larger and more involved than expected).

I'm leaving a few comments regarding the new changes, but otherwise everything LGTM. I'm approving this MP now; feel free to upload the package whenever you feel it's ready.

review: Approve

« Back to merge proposal