Merge ~athos-ribeiro/ubuntu/+source/postgresql-common:fix-set-conffile-regex-bionic into ubuntu/+source/postgresql-common:ubuntu/bionic-devel
| Status: | Approved |
|---|---|
| Approved by: | git-ubuntu bot |
| Approved revision: | not available |
| Proposed branch: | ~athos-ribeiro/ubuntu/+source/postgresql-common:fix-set-conffile-regex-bionic |
| Merge into: | ubuntu/+source/postgresql-common:ubuntu/bionic-devel |
| Diff against target: |
107 lines (+26/-2) 3 files modified
PgCommon.pm (+2/-2) debian/changelog (+6/-0) t/005_PgCommon.t (+18/-0) |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| git-ubuntu bot | Approve | ||
| Bryce Harrington (community) | Approve | ||
| Canonical Server Reporter | Pending | ||
|
Review via email:
|
|||
Description of the change
pg_conftool mistakes regular comments starting with a configuration option for actual commented configuration options.
While the issue does not impact any software features or its usability, it may lead to the deletion of useful comments or documentation in configuration files.
See LP: #2007794 for further reference.
PPA: https:/
DEP8 test results:
* Results:
- postgresql-
+ ✅ postgresql-common on bionic for amd64 @ 11.04.23 12:31:58 Log️ 🗒️
+ ✅ postgresql-common on bionic for arm64 @ 11.04.23 00:12:07 Log️ 🗒️
+ ✅ postgresql-common on bionic for armhf @ 11.04.23 00:11:26 Log️ 🗒️
+ ✅ postgresql-common on bionic for i386 @ 11.04.23 00:14:50 Log️ 🗒️
+ ✅ postgresql-common on bionic for ppc64el @ 11.04.23 00:15:22 Log️ 🗒️
+ ✅ postgresql-common on bionic for s390x @ 11.04.23 00:31:51 Log️ 🗒️
There was an amd64 failure on the first run, which seemed to be unrelated to the change (flakiness).
| Athos Ribeiro (athos-ribeiro) wrote | # |
There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.
I had a bug in the implementation for --release in ppa-dev-tools that was preventing me from seeing the results, but after fixing it
* Triggers:
- Source postgresql-
+ Trigger basic @amd64♻️ Trigger all-proposed @amd64💍
+ Trigger basic @arm64♻️ Trigger all-proposed @arm64💍
+ Trigger basic @armhf♻️ Trigger all-proposed @armhf💍
+ Trigger basic @i386♻️ Trigger all-proposed @i386💍
+ Trigger basic @ppc64el♻️ Trigger all-proposed @ppc64el💍
+ Trigger basic @s390x♻️ Trigger all-proposed @s390x💍
* Results:
- postgresql-
+ ❌ postgresql-common on bionic for amd64 @ 11.04.23 00:16:07 Log️ 🗒️
• default-psql FAIL 🟥
+ ✅ postgresql-common on bionic for amd64 @ 11.04.23 12:31:58 Log️ 🗒️
+ ✅ postgresql-common on bionic for arm64 @ 11.04.23 00:12:07 Log️ 🗒️
+ ✅ postgresql-common on bionic for armhf @ 11.04.23 00:11:26 Log️ 🗒️
+ ✅ postgresql-common on bionic for i386 @ 11.04.23 00:14:50 Log️ 🗒️
+ ✅ postgresql-common on bionic for ppc64el @ 11.04.23 00:15:22 Log️ 🗒️
+ ✅ postgresql-common on bionic for s390x @ 11.04.23 00:31:51 Log️ 🗒️
* Running: (none)
* Waiting: (none)
Looks like the first amd64 test ran and it passed on retrigger.
Otherwise, same changes as the kinetic branch, so see its MP for details.