Code review comment for ~athos-ribeiro/ubuntu/+source/php-doctrine-cache:merge-lp1976624-kinetic

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

The build dependency is needed for the package tests to run during its build.

make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   debian/rules override_dh_auto_test
make[1]: Entering directory '/<<PKGBUILDDIR>>'
memcached -d -u memcache
redis-server --daemonize yes
phpunit --include-path lib --bootstrap vendor/autoload.php
PHP Warning: require_once(Cache/TagInterop/autoload.php): Failed to open stream: No such file or directory in /usr/share/php/Cache/IntegrationTests/autoload.php on line 4
PHPUnit 9.5.20 #StandWithUkraine

Error in bootstrap script: Error:
Failed opening required 'Cache/TagInterop/autoload.php' (include_path='lib:.:/usr/share/php')
#0 /<<PKGBUILDDIR>>/vendor/autoload.php(4): require_once()
#1 /usr/share/php/PHPUnit/Util/FileLoader.php(65): include_once('...')
#2 /usr/share/php/PHPUnit/Util/FileLoader.php(49): PHPUnit\Util\FileLoader::load()
#3 /usr/share/php/PHPUnit/TextUI/Command.php(562): PHPUnit\Util\FileLoader::checkAndLoad()
#4 /usr/share/php/PHPUnit/TextUI/Command.php(342): PHPUnit\TextUI\Command->handleBootstrap()
#5 /usr/share/php/PHPUnit/TextUI/Command.php(111): PHPUnit\TextUI\Command->handleArguments()
#6 /usr/share/php/PHPUnit/TextUI/Command.php(96): PHPUnit\TextUI\Command->run()
#7 /usr/bin/phpunit(73): PHPUnit\TextUI\Command::main()
#8 {main}
make[1]: *** [debian/rules:25: override_dh_auto_test] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
make: *** [debian/rules:3: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2
--------------------------------------------------------------------------------
Build finished at 2022-06-02T18:26:07Z

Finished
--------

What I initially thought was that we could drop the delta in php-cache-integration-tests, which would make it pull the missing dependency for this package during the build (and for DEP8 tests).

But analyzing the delta in php-cache-integration-tests one will find it came from upstream, hence, we are just anticipating here what will be required soon in Debian as well. Then I decided to just merge this one and wait for a new php-cache-integration-tests upstream release so we can forward this delta to Debian.

« Back to merge proposal