Code review comment for ~athos-ribeiro/ubuntu/+source/kerberos-configs:merge-impish

Revision history for this message
Bryce Harrington (bryce) wrote (last edit ):

You don't need to mention the no-change rebuilds as being dropped, since there's no tangible change to the packaging or source code. The reason we bother mentioning drops in the first place is primarily to assist future maintainers identify when packaging/code changes exited the package. Since with no-change rebuilts there are no such changes, there's nothing worth mentioning in the changelog entry.

Similarly, for the Remaining Changes, I've noticed a common practice is to summarize changes so they take less room in the changelog. Especially so for changes we're likely to carry for a while. I guess a general rule of thumb is give enough info for someone to recognize the change enough that they can search through the changelog to find the more detailed original entry.

Anyway, so I think you could simplify your changelog message to just this:

+ * Merge with Debian unstable. Remaining changes:
+ - d/control: set Multi-Arch to foreign to allow this package to be
+ used as a dependency of architecture-dependent packages.

Looks like the delta has been forwarded to Debian, but they've not yet responded:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959982

Regarding dep8 tests, this maybe not so critical since this is a -configs package, but this merge might be a good opportunity to jot down thoughts in LP: #1677880 about how this could be achieved.

review: Needs Fixing

« Back to merge proposal