Merge ~athos-ribeiro/ubuntu/+source/kerberos-configs:merge-impish into ubuntu/+source/kerberos-configs:debian/sid

Proposed by Athos Ribeiro
Status: Approved
Approved by: Bryce Harrington
Approved revision: c1d5f21821c1ee83736eb2c7c86874f84c533cfc
Proposed branch: ~athos-ribeiro/ubuntu/+source/kerberos-configs:merge-impish
Merge into: ubuntu/+source/kerberos-configs:debian/sid
Diff against target: 62 lines (+28/-1)
2 files modified
debian/changelog (+25/-0)
debian/control (+3/-1)
Reviewer Review Type Date Requested Status
Bryce Harrington (community) Approve
Canonical Server Core Reviewers Pending
Review via email: mp+406047@code.staging.launchpad.net

Description of the change

This MP merges kerberos-configs for the impish cycle.

A PPA with the proposed merge is available at https://launchpad.net/~athos-ribeiro/+archive/ubuntu/kerberos-configs-merge-impish/+packages

This package has no autopkgtest test suite.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote (last edit ):

You don't need to mention the no-change rebuilds as being dropped, since there's no tangible change to the packaging or source code. The reason we bother mentioning drops in the first place is primarily to assist future maintainers identify when packaging/code changes exited the package. Since with no-change rebuilts there are no such changes, there's nothing worth mentioning in the changelog entry.

Similarly, for the Remaining Changes, I've noticed a common practice is to summarize changes so they take less room in the changelog. Especially so for changes we're likely to carry for a while. I guess a general rule of thumb is give enough info for someone to recognize the change enough that they can search through the changelog to find the more detailed original entry.

Anyway, so I think you could simplify your changelog message to just this:

+ * Merge with Debian unstable. Remaining changes:
+ - d/control: set Multi-Arch to foreign to allow this package to be
+ used as a dependency of architecture-dependent packages.

Looks like the delta has been forwarded to Debian, but they've not yet responded:
  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=959982

Regarding dep8 tests, this maybe not so critical since this is a -configs package, but this merge might be a good opportunity to jot down thoughts in LP: #1677880 about how this could be achieved.

review: Needs Fixing
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Bryce. I was indeed asking myself if we needed to keep that specific entry.

I fixed the changelog, as you suggested. Would you rather see the dep8 test suite added in this MP, in a separate MP (adding additional delta) or just forwarded to Debian?

Revision history for this message
Bryce Harrington (bryce) wrote :

Oh, I don't expect dep8 tests to be written for this MP, just the changelog fixup. I can go ahead and sponsor this now.

If you do wish to work on a dep8 test at some point, whether to do that in debian and merge here, or in ubuntu (and then forward to them) is down to personal preference I think.

Revision history for this message
Bryce Harrington (bryce) wrote :

triage-impish+21.10:~/pkg/KerberosConfigs/review-mp406047$ dput ubuntu kerberos-configs_2.6+nmu1ubuntu1_source.changesD: Setting host argument.
Checking signature on .changes
gpg: /home/bryce/pkg/KerberosConfigs/review-mp406047/kerberos-configs_2.6+nmu1ubuntu1_source.changes: Valid signature from E603B2578FB8F0FB
Checking signature on .dsc
gpg: /home/bryce/pkg/KerberosConfigs/review-mp406047/kerberos-configs_2.6+nmu1ubuntu1.dsc: Valid signature from E603B2578FB8F0FB
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading kerberos-configs_2.6+nmu1ubuntu1.dsc: done.
  Uploading kerberos-configs_2.6+nmu1ubuntu1.tar.xz: done.
  Uploading kerberos-configs_2.6+nmu1ubuntu1_source.buildinfo: done.
  Uploading kerberos-configs_2.6+nmu1ubuntu1_source.changes: done.
Successfully uploaded packages.
stirling:~/pkg/KerberosConfigs/review-mp406047/kerberos-configs-gu$ git ubuntu tag --upload
stirling:~/pkg/KerberosConfigs/review-mp406047/kerberos-configs-gu$ git push pkg upload/2.6+nmu1ubuntu1
Enumerating objects: 25, done.
Counting objects: 100% (25/25), done.
Delta compression using up to 12 threads
Compressing objects: 100% (20/20), done.
Writing objects: 100% (21/21), 2.56 KiB | 2.56 MiB/s, done.
Total 21 (delta 15), reused 1 (delta 1)
To ssh://git.launchpad.net/ubuntu/+source/kerberos-configs
 * [new tag] upload/2.6+nmu1ubuntu1 -> upload/2.6+nmu1ubuntu1

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches