Merge lp://staging/~astara-drivers/charms/trusty/nova-cloud-controller/api-ready-rebase into lp://staging/~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next

Proposed by Adam Gandelman
Status: Merged
Merged at revision: 221
Proposed branch: lp://staging/~astara-drivers/charms/trusty/nova-cloud-controller/api-ready-rebase
Merge into: lp://staging/~openstack-charmers-archive/charms/trusty/nova-cloud-controller/next
Diff against target: 238 lines (+84/-5)
4 files modified
hooks/nova_cc_hooks.py (+23/-0)
hooks/nova_cc_utils.py (+5/-0)
unit_tests/test_nova_cc_hooks.py (+42/-5)
unit_tests/test_nova_cc_utils.py (+14/-0)
To merge this branch: bzr merge lp://staging/~astara-drivers/charms/trusty/nova-cloud-controller/api-ready-rebase
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+284962@code.staging.launchpad.net
To post a comment you must log in.
216. By Adam Gandelman

Remove duplicate hook trigger

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_unit_test #119 nova-cloud-controller-next for gandelman-a mp284962
    UNIT OK: passed

Build: http://10.245.162.36:8080/job/charm_unit_test/119/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_lint_check #133 nova-cloud-controller-next for gandelman-a mp284962
    LINT OK: passed

Build: http://10.245.162.36:8080/job/charm_lint_check/133/

Revision history for this message
uosci-testing-bot (uosci-testing-bot) wrote :

charm_amulet_test #14 nova-cloud-controller-next for gandelman-a mp284962
    AMULET OK: passed

Build: http://10.245.162.36:8080/job/charm_amulet_test/14/

Revision history for this message
Liam Young (gnuoy) wrote :

Thank you for this contribution, it is very much appreciated. Approved.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches