Merge lp://staging/~asanjar/charms/trusty/hdp-tez/trunk into lp://staging/charms/trusty/hdp-tez
Proposed by
amir sanjar
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 17 | ||||
| Proposed branch: | lp://staging/~asanjar/charms/trusty/hdp-tez/trunk | ||||
| Merge into: | lp://staging/charms/trusty/hdp-tez | ||||
| Diff against target: |
257 lines (+111/-14) 10 files modified
README.md (+4/-3) hooks/hadoop-nodes-relation-broken (+31/-0) hooks/hadoop-nodes-relation-changed (+33/-0) hooks/hdputils.py (+2/-0) hooks/install (+11/-3) hooks/namenode-relation-changed (+8/-3) hooks/resourcemanager-relation-changed (+4/-2) metadata.yaml (+2/-1) tests/10-deploy-tez (+14/-2) tests/hadoop-tez-cluster.yaml (+2/-0) |
||||
| To merge this branch: | bzr merge lp://staging/~asanjar/charms/trusty/hdp-tez/trunk | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Charles Butler (community) | Disapprove | ||
|
Review via email:
|
|||
Description of the change
add openstack changes
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks for the openstack fixes amir. I've verified that these work on OpenStack with some slight modifications.
It appears you were expecting more than a single data node to be in teh deployment, so I increased the number of compute nodes to 2 in the test yaml and it passed with flying colors. We also encourage developers to not leave large swaths of comments in the code as its just messy coding practice - so I've removed this blob from tests/10-deploy-tez
I'm going to reject this particular merge, and push my changes into bigdata-dev namespace and re-open as a proposal for the charmstore.
Thanks for the hard work!