Merge lp://staging/~artmello/ubuntu-system-settings/keyboard_navigation into lp://staging/ubuntu-system-settings
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~artmello/ubuntu-system-settings/keyboard_navigation |
Merge into: | lp://staging/ubuntu-system-settings |
Diff against target: |
445 lines (+246/-14) 7 files modified
src/SystemSettings/ItemPage.qml (+1/-0) src/item-model.cpp (+78/-0) src/item-model.h (+7/-0) src/qml/CategorySection.qml (+21/-2) src/qml/MainWindow.qml (+116/-9) src/qml/UncategorizedItemsView.qml (+22/-2) tests/plugins/main/tst_MainWindow.qml (+1/-1) |
To merge this branch: | bzr merge lp://staging/~artmello/ubuntu-system-settings/keyboard_navigation |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
system-apps-ci-bot | continuous-integration | Approve | |
Ubuntu Touch System Settings | Pending | ||
Review via email: mp+320046@code.staging.launchpad.net |
Commit message
Add support for keyboard navigation:
- Up/Down to navigate between categories
- Left/Right to change focus from first and second column
- Escape to close panel and return to categories when in single column mode
Description of the change
Add support for keyboard navigation:
- Up/Down to navigate between categories
- Left/Right to change focus from first and second column
- Escape to close panel and return to categories when in single column mode
Unmerged revisions
- 1768. By Arthur Mello
-
Fix AP tests
- 1767. By Arthur Mello
-
Fix behavior of Esc and Left keys on single column mode
- 1766. By Arthur Mello
-
Add new keyboard navigation
- Use left/right to change focus from first and second column in 2 column mode
- Use left to close current panel and return to categories in single column mode
- Use Escape to do the same as left - 1765. By Arthur Mello
-
Initial support for keyboard navigation
- Up/Down navigate between categories
FAILED: Continuous integration, rev:1767 /jenkins. canonical. com/system- apps/job/ lp-ubuntu- system- settings- ci/5/ /jenkins. canonical. com/system- apps/job/ build/2317/ console /jenkins. canonical. com/system- apps/job/ build-0- fetch/2316 /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= xenial+ overlay/ 2138/console /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=amd64, release= zesty/2138/ console /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= xenial+ overlay/ 2138/console /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=armhf, release= zesty/2138/ console /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= xenial+ overlay/ 2138/console /jenkins. canonical. com/system- apps/job/ build-2- binpkg/ arch=i386, release= zesty/2138/ console
https:/
Executed test runs:
FAILURE: https:/
SUCCESS: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild: /jenkins. canonical. com/system- apps/job/ lp-ubuntu- system- settings- ci/5/rebuild
https:/