Merge lp://staging/~artmello/ubuntu-system-settings/keyboard-navigation into lp://staging/ubuntu-system-settings
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~artmello/ubuntu-system-settings/keyboard-navigation |
| Merge into: | lp://staging/ubuntu-system-settings |
| Prerequisite: | lp://staging/~artmello/ubuntu-system-settings/category-list-view |
| Diff against target: |
327 lines (+207/-9) 6 files modified
src/item-model.cpp (+82/-0) src/item-model.h (+7/-0) src/qml/MainWindow.qml (+104/-8) tests/mocks/SystemSettings/MockPluginManager.cpp (+11/-0) tests/mocks/SystemSettings/MockPluginManager.h (+2/-0) tests/plugins/main/tst_MainWindow.qml (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~artmello/ubuntu-system-settings/keyboard-navigation |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| system-apps-ci-bot | continuous-integration | Approve | |
| Ubuntu Touch System Settings | Pending | ||
|
Review via email:
|
|||
Commit message
Add new keyboard navigation
- Up/Down navigate between categories
- Use left/right to change focus from first and second column in 2 column mode
- Use left to close current panel and return to categories in single column mode
- Use Escape to do the same as left
Description of the change
Add new keyboard navigation
- Up/Down navigate between categories
- Use left/right to change focus from first and second column in 2 column mode
- Use left to close current panel and return to categories in single column mode
- Use Escape to do the same as left
| system-apps-ci-bot (system-apps-ci-bot) wrote | # |
| system-apps-ci-bot (system-apps-ci-bot) wrote | # |
| system-apps-ci-bot (system-apps-ci-bot) wrote | # |
Unmerged revisions
- 1775. By Arthur Mello
-
Fix AP tests
- 1774. By Arthur Mello
-
Merge with trunk
- 1773. By Arthur Mello
-
Add new keyboard navigation
- Use left/right to change focus from first and second column in 2 column mode
- Use left to close current panel and return to categories in single column mode
- Use Escape to do the same as left - 1772. By Arthur Mello
-
Fix testMainWindow
- 1771. By Arthur Mello
-
Fix Plugins' sorting test
- 1770. By Arthur Mello
-
Disable sorting plugins test
- 1769. By Arthur Mello
-
Change Categories list view to use ListView qml Component
- Change PluginManager to keep only one instance of ItemModel instead of one for each category;
- Change ItemModel to order entries taking category in account;
- Change MainWindow to use ListView instead of Columns;
- Update tests;
FAILED: Continuous integration, rev:1773
https:/
Executed test runs:
FAILURE: https:/
FAILURE: https:/
Click here to trigger a rebuild:
https:/