Ubuntu Push Notifications

Merge lp://staging/~artmello/ubuntu-push/ubuntu-push-remove_notification_list_check into lp://staging/ubuntu-push

  1. ubuntu-push-remove_notification_list_check
  2. Merge into trunk
Proposed by Arthur Mello
Status: Needs review
Proposed branch: lp://staging/~artmello/ubuntu-push/ubuntu-push-remove_notification_list_check
Merge into: lp://staging/ubuntu-push
Diff against target: 79 lines (+0/-35)
2 files modified
click/cnotificationsettings/cnotificationsettings.go (+0/-27)
messaging/messaging.go (+0/-8)
To merge this branch: bzr merge lp://staging/~artmello/ubuntu-push/ubuntu-push-remove_notification_list_check
Reviewer Review Type Date Requested Status
system-apps-ci-bot continuous-integration Needs Fixing
Ubuntu Push Hackers Pending
Review via email: mp+301225@code.staging.launchpad.net

Commit message

Do not check if application can use Notification list
Always display application notification to Notification List if notifications are enabled for that app

Description of the change

Do not check if application can use Notification list
Always display application notification to Notification List if notifications are enabled for that app

To post a comment you must log in.
Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:169
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/18/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1042/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1042
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/939/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/939/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/939/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/18/rebuild

review: Needs Fixing (continuous-integration)
Reply
lp://staging/~artmello/ubuntu-push/ubuntu-push-remove_notification_list_check updated
170. By Arthur Mello

Remove unused include

Revision history for this message
system-apps-ci-bot (system-apps-ci-bot) wrote :

FAILED: Continuous integration, rev:170
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/19/
Executed test runs:
    FAILURE: https://jenkins.canonical.com/system-apps/job/build/1043/console
    SUCCESS: https://jenkins.canonical.com/system-apps/job/build-0-fetch/1043
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=vivid+overlay/940/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=xenial+overlay/940/console
    FAILURE: https://jenkins.canonical.com/system-apps/job/build-1-sourcepkg/release=yakkety/940/console

Click here to trigger a rebuild:
https://jenkins.canonical.com/system-apps/job/lp-ubuntu-push-ci/19/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

170. By Arthur Mello

Remove unused include

169. By Arthur Mello

Do not check if application can use Notification list
Always display application notification to Notification List if notifications are enabled for that app

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches