gallery-app

Merge lp://staging/~artmello/gallery-app/gallery-app-fix_1425563 into lp://staging/gallery-app

  1. gallery-app-fix_1425563
  2. Merge into trunk
Proposed by Arthur Mello
Status: Merged
Approved by: Bill Filler
Approved revision: 1158
Merged at revision: 1176
Proposed branch: lp://staging/~artmello/gallery-app/gallery-app-fix_1425563
Merge into: lp://staging/gallery-app
Prerequisite: lp://staging/~phablet-team/gallery-app/gallery-app-photo-editor
Diff against target: 107 lines (+36/-5)
2 files modified
rc/qml/MediaViewer/MediaViewer.qml (+0/-1)
rc/qml/MediaViewer/SingleMediaViewer.qml (+36/-4)
To merge this branch: bzr merge lp://staging/~artmello/gallery-app/gallery-app-fix_1425563
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Ubuntu Phablet Team Pending
Review via email: mp+252444@code.staging.launchpad.net

Commit message

Do not update PhotoViewer Image sourceSize everytime the app is resized on devices.
That way we will not flicker the image everytime we toggle fullscreen
Animate Image resize

Description of the change

Do not update PhotoViewer Image sourceSize everytime the app is resized on devices.
That way we will not flicker the image everytime we toggle fullscreen
Animate Image resize

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1154
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1129/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/57
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/57
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/57/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/57
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/186
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/715/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/821
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/441
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18704
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/570/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/835
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/835/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1129/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~artmello/gallery-app/gallery-app-fix_1425563 updated
1155. By Arthur Mello

Fix the MouseArea zoom control on SingleMediaViewer.qml

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1155
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1131/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/59
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/190
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/735
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/833
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/455
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18893
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/590
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/865
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/865/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1131/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~artmello/gallery-app/gallery-app-fix_1425563 updated
1156. By Arthur Mello

Should not animate on height while zooming the photo

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1156
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1132/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/60
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/60
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/60/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/60
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/191
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/739/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/834
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/457
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18919
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/594/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/869
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/869/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1132/rebuild

review: Needs Fixing (continuous-integration)
lp://staging/~artmello/gallery-app/gallery-app-fix_1425563 updated
1157. By Arthur Mello

Fix the calculation of maxDimension since the old way was crashing the image provider cache

1158. By Arthur Mello

Only show the high resolution image after it is loaded

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1158
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/1133/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-amd64-ci/61
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/61
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-armhf-ci/61/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-vivid-i386-ci/61
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-vivid-touch/192
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-vivid/740/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-click-autopilot-runner-mako/836
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-click-builder-vivid-armhf/458
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/18927
    FAILURE: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-vivid/595/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/870
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-vivid-amd64/870/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gallery-app-ci/1133/rebuild

review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches