Merge lp://staging/~arthru/prestashoperpconnect/tax-included-in-prices into lp://staging/prestashoperpconnect

Proposed by arthru
Status: Merged
Merged at revision: 277
Proposed branch: lp://staging/~arthru/prestashoperpconnect/tax-included-in-prices
Merge into: lp://staging/prestashoperpconnect
Diff against target: 104 lines (+30/-10)
4 files modified
prestashoperpconnect/prestashop_model.py (+1/-1)
prestashoperpconnect/prestashop_model_view.xml (+1/-0)
prestashoperpconnect/unit/direct_binder.py (+3/-1)
prestashoperpconnect/unit/mapper.py (+25/-8)
To merge this branch: bzr merge lp://staging/~arthru/prestashoperpconnect/tax-included-in-prices
Reviewer Review Type Date Requested Status
Romain Deheele - Camptocamp (community) code review and test Approve
arthru Needs Resubmitting
Review via email: mp+193024@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-10-25.

Description of the change

This propose to either use tax included prices or tax excluded prices for order imports.

To post a comment you must log in.
Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote : Posted in a previous version of this proposal

Hi,

It works on classic sale order lines.
But price unit on shipping line is still tax excluded.

Romain

review: Needs Fixing (code review and test)
Revision history for this message
arthru (arthru) wrote :

I've merged the patch from Romain Deheele (Thanks !).

review: Needs Resubmitting
Revision history for this message
Romain Deheele - Camptocamp (romaindeheele) wrote :

Hi,

Thanks for the merge.
I've manually tested it again, it's ok.

Romain

review: Approve (code review and test)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.