Scratch

Merge lp://staging/~artem-anufrij/scratch/Bugfix-1200522 into lp://staging/~elementary-apps/scratch/scratch

  1. Bugfix-1200522
  2. Merge into scratch
Proposed by Artem Anufrij
Status: Superseded
Proposed branch: lp://staging/~artem-anufrij/scratch/Bugfix-1200522
Merge into: lp://staging/~elementary-apps/scratch/scratch
Diff against target: 149 lines (+27/-17)
3 files modified
plugins/filemanager/FileManagerPlugin.vala (+13/-13)
plugins/filemanager/FileView.vala (+13/-3)
plugins/terminal/terminal.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~artem-anufrij/scratch/Bugfix-1200522
Reviewer Review Type Date Requested Status
Artem Anufrij (community) Approve
Danielle Foré Needs Fixing
Review via email: mp+240185@code.staging.launchpad.net

Description of the change

'save as' opens automatically location highlighted in the File Browser plugin

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

This doesn't seem to work as expected. I'm still getting the folder Scratch was launched from in the Save dialog regardless of the expanded folders or selected file in the file manager plugin

review: Needs Fixing
Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

@Dan:
Have you tested it with file manager, or folder manager? File manager works fine....

Revision history for this message
Danielle Foré (danrabbit) wrote :

File manager. I tried running from the directory and installed.

lp://staging/~artem-anufrij/scratch/Bugfix-1200522 updated
1402. By artem-anufrij

commit

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Mysterious.

I pushed once again the code...

This is the workflow on my system:

https://launchpadlibrarian.net/188886936/Screencast%202014-11-01%2022%3A20%3A38.mp4

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Dan, could you try again?

Revision history for this message
Artem Anufrij (artem-anufrij) wrote :

Please review

review: Needs Resubmitting
Revision history for this message
Artem Anufrij (artem-anufrij) :
review: Approve
Revision history for this message
Artem Anufrij (artem-anufrij) :
review: Approve

Unmerged revisions

1402. By artem-anufrij

commit

1401. By artem-anufrij

'save as' opens automatically location highlighted in the File Browser plugin

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches