Audience

Merge lp://staging/~artem-anufrij/audience/Bugfix-1386040 into lp://staging/~audience-members/audience/trunk

  1. Bugfix-1386040
  2. Merge into trunk
Proposed by Artem Anufrij
Status: Work in progress
Proposed branch: lp://staging/~artem-anufrij/audience/Bugfix-1386040
Merge into: lp://staging/~audience-members/audience/trunk
Diff against target: 179 lines (+144/-3) (has conflicts)
1 file modified
src/Audience.vala (+144/-3)
Text conflict in src/Audience.vala
To merge this branch: bzr merge lp://staging/~artem-anufrij/audience/Bugfix-1386040
Reviewer Review Type Date Requested Status
kay van der Zander (community) code Needs Fixing
Review via email: mp+274643@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-11-11.

Description of the change

Check privacy mode. IF ENABLED: don't save the settings (last videos, current video, process, last folder).

To post a comment you must log in.
Revision history for this message
Viko Adi Rahmawan (vikoadi) wrote : Posted in a previous version of this proposal

I think this process of defining what to save and what to open is a really complex task. As we see in the switchboard we have a blacklisting based on file path and what open it.

Checking this gsettings might be not enough and we need a more sophisticated process involving Zeitgeist , Gtk.RecentManager, etc. And it might be useful for other project too, it would be awesome if it can be a part of Granite.

I don't know about how Security and Privacy is designed in pantheon, and i think it need to be discussed in a bigger forum.

Revision history for this message
Danielle Foré (danrabbit) wrote : Posted in a previous version of this proposal

I think for the purpose of this bug report, it would be acceptable to just not write any changes to gsettings while privacy mode is active.

Revision history for this message
kay van der Zander (kay20) wrote :

hey nice job on including privacy.
still there are some bad parts as in not functional or not readable enough.
please fix them.

review: Needs Fixing (code)
Reply

Unmerged revisions

460. By artem-anufrij

Check privacy mode. IF ENABLE: don't save the settings (last videos, current video, process, last folder).

459. By artem-anufrij

Check privacy mode. IF ENABLE: don't save the settings (last videos, current video, process).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches