Merge ~arighi/qa-regression-testing:support-python2-and-python3 into qa-regression-testing:master

Proposed by Andrea Righi
Status: Rejected
Rejected by: Steve Beattie
Proposed branch: ~arighi/qa-regression-testing:support-python2-and-python3
Merge into: qa-regression-testing:master
Diff against target: 52 lines (+16/-4)
4 files modified
scripts/kernel-security/errno-read.py (+4/-1)
scripts/kernel-security/proc-leaks/dac-bypass.py (+4/-1)
scripts/kernel-security/proc-maps/maps-protection.py (+4/-1)
scripts/test-kernel-security.py (+4/-1)
Reviewer Review Type Date Requested Status
Ubuntu Security Team Pending
Review via email: mp+440700@code.staging.launchpad.net

Description of the change

In lunar we are getting some test failures reporting the error:

 /usr/bin/env: ‘python2’: No such file or directory

Fix by changing the shebang of the scripts in kernel-security to dynamically detect the availability of python2 or python3.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

This overlaps https://code.launchpad.net/~fginther/qa-regression-testing/+git/qa-regression-testing/+merge/440503.

I'd prefer to just convert all of these to python3 as we really have no reason to keep running these with python2 (we have python 3.4 in trusty which is as far back as we would need to run any kernel testing).

I'll propose another MP to address dac-bypass.py and test-kernel-security.py.

Revision history for this message
Francis Ginther (fginther) wrote :

I recommend replacing this MP with https://code.launchpad.net/~fginther/qa-regression-testing/+git/qa-regression-testing/+merge/440800 which applies additional 2to3 updates.

Revision history for this message
Steve Beattie (sbeattie) wrote :

My apologies for not getting to this earlier, other commits have landed that address the same issues.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches