Merge lp://staging/~arges/charm-helpers/fix-lp1308557 into lp://staging/charm-helpers

Proposed by Chris J Arges
Status: Merged
Merged at revision: 143
Proposed branch: lp://staging/~arges/charm-helpers/fix-lp1308557
Merge into: lp://staging/charm-helpers
Diff against target: 33 lines (+3/-3)
2 files modified
charmhelpers/fetch/__init__.py (+1/-1)
tests/fetch/test_fetch.py (+2/-2)
To merge this branch: bzr merge lp://staging/~arges/charm-helpers/fix-lp1308557
Reviewer Review Type Date Requested Status
Marco Ceppi Approve
Review via email: mp+216116@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote :

Chris this LTGM. Please confirm that is has bee tested. I see that you have synced this into a couple of charms so if they work fine then we can ship this.

Revision history for this message
Jorge Niedbalski (niedbalski) wrote :

OK, all tests are passing.

---------------------------------------------------------------------------
TOTAL 2917 220 92%
----------------------------------------------------------------------
Ran 595 tests in 2.259s

OK

PS: test_requirements are not working properly. Proposed MR on this; https://code.launchpad.net/~niedbalski/charm-helpers/fix-test_requirements/+merge/216902

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches