juju-core

Merge lp://staging/~aramh/juju-core/78-mstate-watchers-service-relations-nwo into lp://staging/~juju/juju-core/trunk

Proposed by Aram Hăvărneanu on 2012-09-19

Status:	Work in progress
Proposed branch:	lp://staging/~aramh/juju-core/78-mstate-watchers-service-relations-nwo
Merge into:	lp://staging/~juju/juju-core/trunk
Prerequisite:	lp://staging/~aramh/juju-core/77-mstate-watchers-machine-units-nwo2
Diff against target:	366 lines (+336/-0) 2 files modified mstate/service_test.go (+201/-0) mstate/watcher.go (+135/-0)
To merge this branch:	bzr merge lp://staging/~aramh/juju-core/78-mstate-watchers-service-relations-nwo
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
The Go Language Gophers		2012-09-19	Pending
Review via email: mp+125136@code.staging.launchpad.net

mstate: add service relations watcher

Revision history for this message

Aram Hăvărneanu (aramh) wrote on 2012-09-19:

Reviewers: mp+125136_code.launchpad.net,

Message:
Please take a look.

Description:
mstate: add service relations watcher

(do not edit description out of merge proposal)

Affected files:
   A [revision details]
   M mstate/service_test.go
   M mstate/watcher.go

Revision history for this message

Gustavo Niemeyer (niemeyer) wrote on 2012-09-19:

https://codereview.appspot.com/6531046/diff/1004/mstate/watcher.go#newcode715
mstate/watcher.go:715: func (w *ServiceRelationsWatcher)
mergeChange(changes *RelationsChange, ch watcher.Change) (err error) {
As you suggested, let's filter out so we only act on relevant changes.