lp://staging/~aramh/juju-core/107-state-watchers-units-unassignments6

Branch merges

Propose for merging

1 branch dependent on this one.

On hold for merging into lp://staging/~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-10-17

Diff: 324 lines (+95/-91)

2 files modified

state/machine_test.go (+67/-73)
state/watcher.go (+28/-18)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

677. By Aram Hăvărneanu on 2012-10-17

state: go fmt

676. By Aram Hăvărneanu on 2012-10-17

state: make machine units report unassigment

675. By Roger Peppe on 2012-10-16

environs, juju: require admin-secret

The admin-secret configuration value is required
for bootstrapping and connecting to an environment,
but we can't make config.Config require it because
it should never be pushed into the state.

So we add checks to juju.NewConn and implementations
of Environ.Bootstrap to require that it be set.
This unfortunately means that all tests must
connect with authentication set, which means
the changes are necessarily bulky.

R=TheMue, dfc, fwereade, niemeyer
CC=
https://codereview.appspot.com/6653050

674. By Dave Cheney on 2012-10-15

cmd/juju: add remove-unit subcommand

R=fwereade, niemeyer, rog
CC=
https://codereview.appspot.com/6651060

673. By Gustavo Niemeyer on 2012-10-15

state: fix firewall-mode tests

Firewall mode default is now spelled as "".

R=
CC=
https://codereview.appspot.com/6699044

672. By Roger Peppe on 2012-10-15

environs/ec2: tear down suite properly

LiveTests wasn't destroying the environment.

Also simplify ec2.Destroy a little, now that the AllInstances
method exists.

R=fwereade, dfc, niemeyer
CC=
https://codereview.appspot.com/6646051

671. By Frank Mueller on 2012-10-15

environs: added global open/close/ports

Added the definition of OpenPorts(), ClosePorts() and Ports()
to Environ and changed the implementations of dummy and ec2.
dummy only supports instance firewall mode, ec2 both. The
common test for the global mode is skipped if the environment
does not support that mode.

R=niemeyer
CC=
https://codereview.appspot.com/6652047

670. By Frank Mueller on 2012-10-15

environs: ec2 and dummy default to instance

The validation of the configuration for the providers
ec2 and dummy now exchanges "default" with "instance".
The implementations of the global mode has been rolled
back to avoid failing tests. A later change will
prohibit opening and closing of ports on instances
in the global mode.

R=niemeyer, fwereade, <email address hidden>
CC=
https://codereview.appspot.com/6653043

669. By Roger Peppe on 2012-10-15

cmd/{jujud,juju}: no JujuConnSuite in btstrp test

The tests should not be running on an already-bootstrapped
environment, which is what JujuConnSuite provides.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6601067

668. By Roger Peppe on 2012-10-12

environs/jujutest: move fixtures

It's more conventional to have them next to the tests.

R=aram, TheMue
CC=
https://codereview.appspot.com/6651062