Apport

Merge ~apport-hackers/apport/+git/apport-old:journal-errors-window into ~apport-hackers/apport/+git/apport-old:main

  1. Git
  2. lp:~apport-hackers/apport/+git/apport-old
  3. journal-errors-window
  4. Merge into main
Proposed by Brian Murray
Status: Merged
Merge reported by: Benjamin Drung
Merged at revision: 40b1733a1b5abdaae87297d858710dea437de527
Proposed branch: ~apport-hackers/apport/+git/apport-old:journal-errors-window
Merge into: ~apport-hackers/apport/+git/apport-old:main
Diff against target: 33 lines (+13/-2)
1 file modified
data/general-hooks/generic.py (+13/-2)
Reviewer Review Type Date Requested Status
Benjamin Drung Approve
Review via email: mp+422775@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

By request of the desktop team.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Thank you so much. This will make a significant difference to desktop bug triage where we need to see what got logged at the time of the crash.

Revision history for this message
Benjamin Drung (bdrung) wrote :

Thanks for the patch. I have some improvement suggestions:
1) Add a ProblemReport.get_date() method to directly return the date as datetime object.
2) Move the new logic into a separate function
3) Split out the common parts of the command
4) Add the bug reference and bug description to the commit

Here are the two resulting commits: https://code.launchpad.net/~apport-hackers/apport/+git/apport/+ref/journal-errors-window-v2

What do you think?

review: Needs Information
Revision history for this message
Benjamin Drung (bdrung) :
review: Approve
Revision history for this message
Benjamin Drung (bdrung) wrote :

Merged my adaption of this change.

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: