Unity

Merge lp://staging/~apinheiro/unity/a11y-a11y-always-on into lp://staging/unity

a11y-a11y-always-on
Merge into trunk

Proposed by Alejandro Piñeiro on 2012-07-11

Status:

Rejected

Rejected by:

Andrea Azzarone on 2012-09-06

Proposed branch:

lp://staging/~apinheiro/unity/a11y-a11y-always-on

Merge into:

lp://staging/unity

Diff against target:

354 lines (+12/-242)

5 files modified

CMakeLists.txt (+1/-2)
HACKING (+1/-0)
plugins/unityshell/src/unitya11y.cpp (+7/-123)
services/CMakeLists.txt (+1/-1)
services/panel-a11y.c (+2/-116)

To merge this branch:

bzr merge lp://staging/~apinheiro/unity/a11y-a11y-always-on

Related bugs:

Bug #1023542: [FFe] [a11y] Unity and unity-panel a11y initialization need to be ported to atk-bridge library	Undecided	Fix Released
Bug #1046582: Update to 2.5.91	Wishlist	Fix Released

Link a bug report

Reviewer	Date Requested	Status
Andrea Azzarone (community)	2012-07-16	Disapprove on 2012-09-06
Marco Trevisan (Treviño)		Approve on 2012-07-20
Alex Launi	2012-07-11	Pending
Review via email: mp+114479@code.staging.launchpad.net

Commit message

a11y: Port unity3d and panel service accessibility init to atk-bridge

https://code.launchpad.net/bugs/1023542

Description of the change

See bug 1023542 for the reasons to do this merge.

After this merge:
* Accessibility will be initialized using a library call instead of a module (plugin) runtime-load
* Accessibility would be always on. Take into account that in the last releases of at-spi2-core and at-spi2-atk extra effort was done to not affect the system if no AT (like Orca) is listening. So right now bridge intialized + no AT is listening should be equivalent to not have the bridge initialized (aclaration added for people worried about performance and memory lose).

Revision history for this message

Marco Trevisan (Treviño) (3v1n0) wrote on 2012-07-13:

Once the conflict it's fixed, this is ok for me.

Revision history for this message

Alejandro Piñeiro (apinheiro) wrote on 2012-07-16:

> Once the conflict it's fixed, this is ok for me.

What conflict? Do you mean the new dependency?

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2012-07-16:

> > Once the conflict it's fixed, this is ok for me.
>
> What conflict? Do you mean the new dependency?

8 +<<<<<<< TREE
9
10 set (UNITY_PLUGIN_DEPS "compiz;nux-3.0>=3.0.0;libbamf3;dee-1.0;gio-2.0;gio-unix-2.0;dbusmenu-glib-0.4;x11;libstartup-notification-1.0;gthread-2.0;indicator3-0.4>=0.4.90;atk;unity-misc>=0.4.0;gconf-2.0;libutouch-geis;gtk+-3.0>=3.1;sigc++-2.0;json-glib-1.0;libnotify;xfixes")
11
12 +=======
13 +set (UNITY_PLUGIN_DEPS "compiz;nux-2.0>=2.0.0;libbamf3;dee-1.0;gio-2.0;gio-unix-2.0;dbusmenu-glib-0.4;x11;libstartup-notification-1.0;gthread-2.0;indicator3-0.4>=0.4.90;atk;atk-bridge-2.0;unity-misc>=0.4.0;gconf-2.0;libutouch-geis;gtk+-3.0>=3.1;sigc++-2.0;json-glib-1.0;libnotify;gnome-desktop-3.0;xfixes")
14 +>>>>>>> MERGE-SOURCE

review: Needs Fixing

Revision history for this message

Alejandro Piñeiro (apinheiro) wrote on 2012-07-19:

> > > Once the conflict it's fixed, this is ok for me.
> >
> > What conflict? Do you mean the new dependency?
>
> 8 +<<<<<<< TREE
> 9
> 10 set (UNITY_PLUGIN_DEPS
> "compiz;nux-3.0>=3.0.0;libbamf3;dee-1.0;gio-2.0;gio-unix-2.0;dbusmenu-
> glib-0.4;x11;libstartup-
> notification-1.0;gthread-2.0;indicator3-0.4>=0.4.90;atk;unity-
> misc>=0.4.0;gconf-2.0;libutouch-geis;gtk+-3.0>=3.1;sigc++-2.0;json-
> glib-1.0;libnotify;xfixes")
> 11
> 12 +=======
> 13 +set (UNITY_PLUGIN_DEPS
> "compiz;nux-2.0>=2.0.0;libbamf3;dee-1.0;gio-2.0;gio-unix-2.0;dbusmenu-
> glib-0.4;x11;libstartup-
> notification-1.0;gthread-2.0;indicator3-0.4>=0.4.90;atk;atk-bridge-2.0;unity-
> misc>=0.4.0;gconf-2.0;libutouch-geis;gtk+-3.0>=3.1;sigc++-2.0;json-
> glib-1.0;libnotify;gnome-desktop-3.0;xfixes")
> 14 +>>>>>>> MERGE-SOURCE