Merge lp://staging/~anybox/openobject-client-web/bad-cherrypy-warning into lp://staging/openobject-client-web
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~anybox/openobject-client-web/bad-cherrypy-warning |
| Merge into: | lp://staging/openobject-client-web |
| Diff against target: |
86 lines (+20/-9) 3 files modified
addons/openerp/static/javascript/openerp/openerp.base.js (+11/-9) doc/openerp-web.cfg (+1/-0) openobject/static/javascript/openobject/openobject.http.js (+8/-0) |
| To merge this branch: | bzr merge lp://staging/~anybox/openobject-client-web/bad-cherrypy-warning |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| OpenERP Core Team | Pending | ||
|
Review via email:
|
|||
Description of the change
Merge related to https:/
When using cherrypy 3.1 and a reverse proxy, we get 408 and 502 errors very often, unless disabling keepalive in the apache config, or raising the default socket_timeout in cherrypy. This is a bug in cherrypy as documented in the bug report, which should be solved in cherrypy 3.1.3.
In the meantime, when this problem occurs, ajax requests fail silently, thus leading to bizarre behaviours:
- missing menuitems
- ir.ui.menu view opening instead of the wanted view.
I have :
1) added an ajaxError handler to catch these errors and display a jquery fancybox with the error code.
2) raised the socket_timeout to 60s in the default config
I've used jQuery to send the ajaxError signal because Mochikit doesn't want to sent it.
Unmerged revisions
- 4725. By Christophe Combelles
-
[FIX] Don't fail silently if an ajax request fails. It leads to un predictable
behaviour (missing menuitems, wrong view opened). Display an error popup
instead. This happens very often with cherrypy 3.1 and a reverse proxy. It will
help people diagnosing https://bugs.launchpad .net/bugs/ 705312 more quickly
The related problem should disappear with cherrypy >= 3.1.3
