Aeroo Reports

Merge lp://staging/~anybox/aeroo/fix-upgrade into lp://staging/~anybox/aeroo/7.0-anybox

  1. fix-upgrade
  2. Merge into 7.0-anybox
Proposed by Georges Racinet
Status: Merged
Merged at revision: 37
Proposed branch: lp://staging/~anybox/aeroo/fix-upgrade
Merge into: lp://staging/~anybox/aeroo/7.0-anybox
Diff against target: 196 lines (+91/-13)
6 files modified
report_aeroo/report_xml.py (+11/-6)
report_aeroo_ooo/DocumentConverter.py (+6/-6)
report_aeroo_ooo/check_deps.py (+8/-0)
report_aeroo_ooo/report.py (+28/-1)
report_aeroo_ooo/tests/__init__.py (+4/-0)
report_aeroo_ooo/tests/test_service.py (+34/-0)
To merge this branch: bzr merge lp://staging/~anybox/aeroo/fix-upgrade
Reviewer Review Type Date Requested Status
Christophe Combelles read only, no try Approve
Review via email: mp+214389@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-04-05.

Description of the change

To test, take any customer project using an earlier version of aeroo (no restart_ooo_cmd column in oo_config table), and perform an upgrade with the upgrade script provided by the recipe.

A quicker test is to check if the server starts *without -u report_aeroo_ooo*

Note that I am also tempted by fixing the bare excepts once the fix itself is more mature.

I'm asking ccomb, but any comments are welcome, and especially further tests by the Anybox team on customer projects.

To post a comment you must log in.
Revision history for this message
Christophe Combelles (ccomb) wrote :

+1 to replace the bare exception and add uncatched exceptions as they appear

review: Needs Fixing (read only, no try)
lp://staging/~anybox/aeroo/fix-upgrade updated
38. By Georges Racinet <email address hidden>

Removed some bare excepts

This did not change the behaviour for me. But exception treatment is so
messy in aeroo that I could not see the warning in the except: block

I could see parts of the module that systematically wrap and reraise everything
as Exception

Revision history for this message
Georges Racinet (gracinet) wrote :

@ccomb: removed the two bare excepts I highlited earlier. Are you satisfied ?
I'll work on the other aspects of exception handling in other branches, it's a different topic in my eyes.

Revision history for this message
Christophe Combelles (ccomb) :
review: Approve (read only, no try)
lp://staging/~anybox/aeroo/fix-upgrade updated
39. By Pierre Verkest

use exception message

40. By Pierre Verkest

[FIX]use Message instead message from uno exception

41. By Georges Racinet

[FIX] (temp) graceful instantiation of OOo service depended on bare except

put a big comment in check_deps indicating how a proper fix of this terrible
entanglement should look

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches