Sudoku App

Merge lp://staging/~anthonywong/sudoku-app/better-i18n into lp://staging/sudoku-app

  1. better-i18n
  2. Merge into trunk
Proposed by Anthony Wong
Status: Merged
Approved by: David Planella
Approved revision: 211
Merged at revision: 212
Proposed branch: lp://staging/~anthonywong/sudoku-app/better-i18n
Merge into: lp://staging/sudoku-app
Diff against target: 422 lines (+158/-74)
4 files modified
components/HighscoresTab.qml (+2/-1)
components/SudokuBlocksGrid.qml (+11/-14)
po/sudoku-app.pot (+143/-58)
sudoku-app.qml (+2/-1)
To merge this branch: bzr merge lp://staging/~anthonywong/sudoku-app/better-i18n
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
David Planella Approve
Review via email: mp+222925@code.staging.launchpad.net

Commit message

Better i18n.

To post a comment you must log in.
Revision history for this message
David Planella (dpm) wrote :

Looks good to me, thanks! Just a small inline comment.

review: Approve
Revision history for this message
David Planella (dpm) wrote :

Anthony, what do you think of the inline comment? Would you be happy to apply the change and then get it merger?

review: Needs Information
lp://staging/~anthonywong/sudoku-app/better-i18n updated
211. By Anthony Wong

Extract common expressions into a variable.

Revision history for this message
David Planella (dpm) wrote :

Looks good to me now, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches