Merge lp://staging/~ansharyan015/drizzle/regex_policy_dynamic_fix into lp://staging/drizzle
Proposed by
Daniel Nichter
| Status: | Merged |
|---|---|
| Approved by: | Brian Aker |
| Approved revision: | 2566 |
| Merged at revision: | 2566 |
| Proposed branch: | lp://staging/~ansharyan015/drizzle/regex_policy_dynamic_fix |
| Merge into: | lp://staging/drizzle |
| Diff against target: |
424 lines (+206/-61) 9 files modified
plugin/regex_policy/docs/index.rst (+17/-1) plugin/regex_policy/module.cc (+136/-56) plugin/regex_policy/policy.h (+11/-4) plugin/regex_policy/tests/r/dynamic_plugin.result (+13/-0) plugin/regex_policy/tests/t/dynamic.policy1 (+3/-0) plugin/regex_policy/tests/t/dynamic.policy2 (+3/-0) plugin/regex_policy/tests/t/dynamic.policy3 (+3/-0) plugin/regex_policy/tests/t/dynamic_plugin-master.opt (+1/-0) plugin/regex_policy/tests/t/dynamic_plugin.test (+19/-0) |
| To merge this branch: | bzr merge lp://staging/~ansharyan015/drizzle/regex_policy_dynamic_fix |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Nichter (community) | code review | Approve | |
| Drizzle Merge Team | Pending | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Daniel Nichter (daniel-nichter) | # |
review:
Approve
(code review)
Revision history for this message
| Olaf van der Spek (olafvdspek) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
> bool Policy:
Shouldn't this be a const&?
I also noticed some strings are passed by value while they should be passed by const& too.
Don't forget to use spaces instead of tabs.