Merge lp://staging/~angeloc/unity-lens-files/fix-for-837810 into lp://staging/unity-lens-files
Proposed by
Angelo Compagnucci
Status: | Rejected |
---|---|
Rejected by: | Michal Hruby |
Proposed branch: | lp://staging/~angeloc/unity-lens-files/fix-for-837810 |
Merge into: | lp://staging/unity-lens-files |
Diff against target: |
41 lines (+12/-1) 1 file modified
src/folder.vala (+12/-1) |
To merge this branch: | bzr merge lp://staging/~angeloc/unity-lens-files/fix-for-837810 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Michal Hruby (community) | Needs Fixing | ||
Review via email: mp+97924@code.staging.launchpad.net |
Description of the change
Added desktop to favourites in files and folders lens.
To post a comment you must log in.
Thanks for this! A couple of comments:
8 + string uri_desktop = "file://" + @"$(Environment .get_user_ special_ dir(UserDirecto ry.DESKTOP) )";
Don't do this pls, use Gio's File.new_for_path and the get_uri () method in the File interface.
17 + var desktop_ display_ name = Uri.unescape_string (uri_desktop); display_ name = Filename. display_ basename (desktop_ display_ name);
18 + desktop_
Eeek, again, we have File.get_ parse_name( )
I also think that the desktop bookmark (which isn't a bookmark) should be last in the list, so it doesn't stick out.