Photos Lens

Merge lp://staging/~andrewmccarthy/unity-lens-photos/less-tags-in-preview into lp://staging/unity-lens-photos

  1. less-tags-in-preview
  2. Merge into trunk
Proposed by Andrew McCarthy
Status: Needs review
Proposed branch: lp://staging/~andrewmccarthy/unity-lens-photos/less-tags-in-preview
Merge into: lp://staging/unity-lens-photos
Diff against target: 38 lines (+19/-2)
1 file modified
src/unity_shotwell_daemon.py (+19/-2)
To merge this branch: bzr merge lp://staging/~andrewmccarthy/unity-lens-photos/less-tags-in-preview
Reviewer Review Type Date Requested Status
David Callé Approve
Review via email: mp+168875@code.staging.launchpad.net

Description of the change

Tidies up the display of tags in shotwell photo previews by changing to a newline-separated list, and also removing duplicate prefixes in hierarchical tags.

To post a comment you must log in.
Revision history for this message
David Callé (davidc3) wrote :

Looks better. +1

review: Approve
Reply
Revision history for this message
Michael Terry (mterry) wrote :

Do we want design feedback on this?

Reply
Revision history for this message
David Callé (davidc3) wrote :

Newlines in infohints have been part of discussed design solutions for previews, not for this specific scope, though.
I will add screenshots to the bug report and ping John Lea about it tomorrow.

Reply
Revision history for this message
David Callé (davidc3) wrote :

Andrew, what do you think about removing leading "/" at the beginning of hierarchical tags strings?
It also prevents top level tags to be displayed as "/tag" when they are displayed on their own.

with something like: tags_raw = [t.lstrip('/') for t in tags_raw]

http://ubuntuone.com/2ZML0uRP9p9CJJLJmm0jgU

Reply
Revision history for this message
Andrew McCarthy (andrewmccarthy) wrote :

Hi David, yes stripping the leading '/' does look better.

Reply
Revision history for this message
David Callé (davidc3) wrote :

Andrew, can you add the change, so we can get it reviewed by design?

Reply
lp://staging/~andrewmccarthy/unity-lens-photos/less-tags-in-preview updated
145. By Andrew McCarthy

Remove leading slash in Shotwell's hierarchical tags.

Revision history for this message
Andrew McCarthy (andrewmccarthy) wrote :

Hi David,

Just to let you know I added that change a few days ago. I thought it would send an email notification but I didn't see one at my end.

Cheers,

Andrew

Reply

Unmerged revisions

145. By Andrew McCarthy

Remove leading slash in Shotwell's hierarchical tags.

144. By Andrew McCarthy

Reduce number of tags shown in preview by merging hierarchy into one. Also separate tags with newlines, not commas.

For tags in a hierarchy such as A/B/C/D, a photo tagged with D is stored
(in shotwell) as having tags A, A/B, A/B/C and A/B/C/D. This patch removes
A, A/B and A/B/C, only showing A/B/C/D.

Tags are also listed separated with newlines rather than commas so they're
less likely to run out of space.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: