Merge lp://staging/~andrewjbeach/juju-release-tools/s3-container-arg into lp://staging/juju-release-tools

Proposed by Andrew James Beach
Status: Merged
Merged at revision: 355
Proposed branch: lp://staging/~andrewjbeach/juju-release-tools/s3-container-arg
Merge into: lp://staging/juju-release-tools
Diff against target: 344 lines (+57/-42)
4 files modified (+15/-11) (+5/-4)
tests/ (+36/-26)
tests/ (+1/-1)
To merge this branch: bzr merge lp://staging/~andrewjbeach/juju-release-tools/s3-container-arg
Reviewer Review Type Date Requested Status
Curtis Hovey (community) code Approve
Review via email:

Description of the change

Added -s/--s3-container as a command line argument to

The preset value is now only used as a default, the value is passed down to
where it is used.

The test file now uses a fake value to help sperate the tests from any actual
runs of the script.

In addition I fixed some things scattered throughout that was causing
`make lint` to complain, just to clean the board.

Some more tests should be added but the diff was getting rather large.

To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

Thank you.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches